From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F680C433E0 for ; Mon, 18 Jan 2021 17:22:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0DBC22CA0 for ; Mon, 18 Jan 2021 17:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436513AbhARRWL convert rfc822-to-8bit (ORCPT ); Mon, 18 Jan 2021 12:22:11 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:60767 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406875AbhARRWF (ORCPT ); Mon, 18 Jan 2021 12:22:05 -0500 X-Greylist: delayed 6969 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Jan 2021 12:22:05 EST X-Originating-IP: 86.201.233.230 Received: from xps13 (lfbn-tou-1-151-230.w86-201.abo.wanadoo.fr [86.201.233.230]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id EB838FF806; Mon, 18 Jan 2021 17:21:18 +0000 (UTC) Date: Mon, 18 Jan 2021 18:21:17 +0100 From: Miquel Raynal To: Rob Herring Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-i3c@lists.infradead.org, Thomas Petazzoni , Conor Culhane , Rajeev Huralikoppi , Nicolas Pitre Subject: Re: [PATCH v4 1/6] dt-bindings: i3c: Convert controller description to yaml Message-ID: <20210118182117.311feb44@xps13> In-Reply-To: <20210115170312.GA1434283@robh.at.kernel.org> References: <20210114175558.17097-1-miquel.raynal@bootlin.com> <20210114175558.17097-2-miquel.raynal@bootlin.com> <20210115170312.GA1434283@robh.at.kernel.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, Just another question. > > +patternProperties: > > + "^.*@[0-9a-f]+$": > > You can drop '^.*': > > "@[0-9a-f]+$" Here you advise to drop the beginning + wildcard of the regex matching for I2C children, which indeed makes sense to me. [...] > > + "^.*@[0-9a-f]+,[0-9a-f]+$": Later in the file, we use another regex to match I3C devices. But here if I drop ^.* from the regex, I get the following error: schemas/i3c/i3c.yaml: ignoring, error in schema: patternProperties: @[0-9a-f]+,[0-9a-f]+$ /i3c.yaml: patternProperties:@[0-9a-f]+,[0-9a-f]+$: 'oneOf' conditional failed, one must be fixed: Additional properties are not allowed ('properties', 'required' were unexpected) /i3c.yaml: patternProperties:@[0-9a-f]+,[0-9a-f]+$: 'oneOf' conditional failed, one must be fixed: 'enum' is a required property 'const' is a required property Additional properties are not allowed ('properties', 'required', 'type' were unexpected) /i3c.yaml: patternProperties:@[0-9a-f]+,[0-9a-f]+$: 'oneOf' conditional failed, one must be fixed: '$ref' is a required property 'allOf' is a required property 'boolean' was expected I can keep this extra "^.*" but I would like to understand the error better because this does not look right. Thanks, Miquèl