From: Rob Herring <robh@kernel.org>
To: Philip Chen <philipchen@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>,
dianders@chromium.org, Benson Leung <bleung@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
swboyd@chromium.org, dmitry.torokhov@gmail.com,
LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v6 1/3] dt-bindings: input: Create macros for cros-ec keymap
Date: Wed, 20 Jan 2021 09:49:52 -0600 [thread overview]
Message-ID: <20210120154952.GA212597@robh.at.kernel.org> (raw)
In-Reply-To: <20210115143555.v6.1.Iaa8a60cf2ed4b7ad5e2fbb4ad76a1c600ee36113@changeid>
On Fri, 15 Jan 2021 14:36:15 -0800, Philip Chen wrote:
> In Chrome OS, the keyboard matrix can be split to two groups:
>
> The keymap for the top row keys can be customized based on OEM
> preference, while the keymap for the other keys is generic/fixed
> across boards.
>
> This patch creates marcos for the keymaps of these two groups, making
> it easier to reuse the generic portion of keymap when we override the
> keymap in the board-specific dts for custom top row design.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP
>
> include/dt-bindings/input/cros-ec-keyboard.h | 103 +++++++++++++++++++
> 1 file changed, 103 insertions(+)
> create mode 100644 include/dt-bindings/input/cros-ec-keyboard.h
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
next prev parent reply other threads:[~2021-01-20 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 22:36 [PATCH v6 1/3] dt-bindings: input: Create macros for cros-ec keymap Philip Chen
2021-01-15 22:36 ` [PATCH v6 2/3] ARM: dts: cros-ec-keyboard: Use keymap macros Philip Chen
2021-01-15 22:38 ` Stephen Boyd
2021-02-23 5:39 ` Dmitry Torokhov
2021-01-15 22:36 ` [PATCH v6 3/3] dt-bindings: input: Fix the keymap for LOCK key Philip Chen
2021-01-15 22:39 ` Stephen Boyd
2021-02-04 23:59 ` Philip Chen
2021-02-05 21:13 ` Rob Herring
2021-02-23 5:39 ` Dmitry Torokhov
2021-01-15 22:38 ` [PATCH v6 1/3] dt-bindings: input: Create macros for cros-ec keymap Stephen Boyd
2021-01-15 22:59 ` Philip Chen
2021-01-20 15:49 ` Rob Herring [this message]
2021-02-23 5:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120154952.GA212597@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).