From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: srikanth.thokala@intel.com, bhelgaas@google.com,
robh+dt@kernel.org, lorenzo.pieralisi@arm.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
mgross@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com,
mallikarjunappa.sangannavar@intel.com
Subject: Re: [PATCH v6 2/2] PCI: keembay: Add support for Intel Keem Bay
Date: Thu, 21 Jan 2021 15:11:13 -0600 [thread overview]
Message-ID: <20210121211113.GA2691064@bjorn-Precision-5520> (raw)
In-Reply-To: <YAnnALx/ZHJ+Euhq@smile.fi.intel.com>
On Thu, Jan 21, 2021 at 10:41:36PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 21, 2021 at 01:52:06PM -0600, Bjorn Helgaas wrote:
> > On Fri, Jan 22, 2021 at 08:56:10AM +0530, srikanth.thokala@intel.com wrote:
> > <checks MAINTAINERS> ... yep, all previous entries are in alphabetical
> > order. This new one just got dropped at the end.
> >
> > I feel like a broken record, but please, please, take a look at the
> > surrounding code/text/whatever, and MAKE YOUR NEW STUFF MATCH THE
> > EXISTING STYLE. We want the whole thing to be reasonably consistent
> > so readers can make sense of it without being confused by the
> > idiosyncrasies of every contributor.
>
> I guess even checkpatch.pl should complain about this these days.
Maybe so. But paying attention to the surrounding content can prevent
a whole host of style problems that checkpatch.pl can't catch.
We call these changes "patches," but that's an unfortunate term. It
suggests a band-aid, which is something very obvious. If a Linux
change is done well, a reader should not be able to tell that it was
added later. It should look like it was always there from the very
beginning.
Bjorn
next prev parent reply other threads:[~2021-01-21 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 3:26 [PATCH v6 0/2] PCI: keembay: Add support for Intel Keem Bay srikanth.thokala
2021-01-22 3:26 ` [PATCH v6 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe controller srikanth.thokala
2021-01-22 3:26 ` [PATCH v6 2/2] PCI: keembay: Add support for Intel Keem Bay srikanth.thokala
2021-01-21 19:52 ` Bjorn Helgaas
2021-01-21 20:41 ` Andy Shevchenko
2021-01-21 21:11 ` Bjorn Helgaas [this message]
2021-01-22 20:08 ` Thokala, Srikanth
2021-01-22 19:20 ` Thokala, Srikanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121211113.GA2691064@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=srikanth.thokala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox