From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Daniel Walker <dwalker@fifo99.com>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra
Date: Fri, 22 Jan 2021 20:32:41 +0000 [thread overview]
Message-ID: <20210122203240.GS3710@zorba> (raw)
In-Reply-To: <185100f4-67f1-140b-ad01-9997891e68da@xilinx.com>
On Fri, Jan 22, 2021 at 09:48:53AM +0100, Michal Simek wrote:
> Hi Daniel,
>
> On 1/22/21 12:12 AM, Daniel Walker wrote:
> > Add Petra and Hellcat dts file. These platforms are based on
> > the Xilinx Zynqmp platform.
> >
> > Signed-off-by: Daniel Walker <dwalker@fifo99.com>
> > Cc: xe-linux-external@cisco.com
> > ---
> > arch/arm64/boot/dts/xilinx/Makefile | 2 +
> > .../boot/dts/xilinx/zynqmp-petra-hellcat.dts | 856 ++++++++++++++++++
> > arch/arm64/boot/dts/xilinx/zynqmp-petra.dts | 847 +++++++++++++++++
> > 3 files changed, 1705 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra-hellcat.dts
> > create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra.dts
>
> First of all I can't see 2/2.
It wasn't being submitted to you. But here it is if you care to look at it.
https://lkml.org/lkml/2021/1/21/1468
>
> Long time ago we said that we are not going to push any PL related
> configurations. It means all below can't be merged.
> And there are also coding style issues.
You'll need to explain this more. It's likely this was added at the suggestion of
Xilinx. If it can't be upstreamed what should we replace it with ?
I will review your other comments and re-submit.
Daniel
next prev parent reply other threads:[~2021-01-22 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 23:12 [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra Daniel Walker
2021-01-21 23:58 ` Marcel Ziswiler
2021-01-22 8:48 ` Michal Simek
2021-01-22 20:32 ` Daniel Walker (danielwa) [this message]
2021-01-25 7:52 ` Michal Simek
2021-01-25 21:04 ` Daniel Walker (danielwa)
2021-01-26 9:16 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122203240.GS3710@zorba \
--to=danielwa@cisco.com \
--cc=devicetree@vger.kernel.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).