Re: [PATCH 1/4] iio: adis: add helpers for locking

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 21 Jan 2021 12:49:51 +0100
Nuno Sá <nuno.sa@analog.com> wrote:

> Add some helpers to lock and unlock the device.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Hi Nuno

For a patch like this I'd also expect to see it immediately used in
all relevant places in the driver. I don't want a mixture
going forwards of this vs direct access to the lock.

No need to separate that into two patches for such a simple case
just introduce this and put it to use.  There aren't that
many call sites anyway from a quick grep.

Thanks,

Jonathan



> ---
>  include/linux/iio/imu/adis.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h
> index 04e96d688ba9..f9b728d490b1 100644
> --- a/include/linux/iio/imu/adis.h
> +++ b/include/linux/iio/imu/adis.h
> @@ -428,6 +428,16 @@ static inline int adis_initial_startup(struct adis *adis)
>  	return ret;
>  }
>  
> +static inline void adis_dev_lock(struct adis *adis)
> +{
> +	mutex_lock(&adis->state_lock);
> +}
> +
> +static inline void adis_dev_unlock(struct adis *adis)
> +{
> +	mutex_unlock(&adis->state_lock);
> +}
> +
>  int adis_single_conversion(struct iio_dev *indio_dev,
>  	const struct iio_chan_spec *chan, unsigned int error_mask,
>  	int *val);