devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Mark Brown <broonie@kernel.org>,
	Daniel Walker <dwalker@fifo99.com>,
	"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra
Date: Mon, 25 Jan 2021 21:04:19 +0000	[thread overview]
Message-ID: <20210125210419.GU3710@zorba> (raw)
In-Reply-To: <849cc330-8545-f1cd-1715-5244e399897e@xilinx.com>

On Mon, Jan 25, 2021 at 08:52:01AM +0100, Michal Simek wrote:
> > 
> >>
> >> Long time ago we said that we are not going to push any PL related
> >> configurations. It means all below can't be merged.
> >> And there are also coding style issues.
> > 
> > You'll need to explain this more. It's likely this was added at the suggestion of
> > Xilinx. If it can't be upstreamed what should we replace it with ?
> 
> No idea who gave you this suggestion from Xilinx.
 
Just an FYI , I didn't write this dts or work on it's original development so I
can't name names.

> I had similar thread with Michael Walle about supporting Ebang board.
> PL depends on your custom design and can change quite quickly that's
> there is no good/bad configuration. That's why all of them can be valid
> and kernel is not the right location to store thousands of
> configurations (likely in overlay form). That's why only fixed
> configurations for PS are added to kernel.
> And I prefer if there is any good reason behind why these platforms
> should be added.

I'm not sure what your talking about above .. Are you suggesting the changes in
my DTS will change quickly ? They have been the same for years , we don't plan
to change them. This DTS is not a prototype it's a released Cisco product.

If I did delete this "PL configuration" where would you expect it to re-appear ?
Typically things which aren't upstreamable are transformed into something else,
it's rare that something is just removed and has no transformation.

Daniel

  reply	other threads:[~2021-01-25 23:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 23:12 [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra Daniel Walker
2021-01-21 23:58 ` Marcel Ziswiler
2021-01-22  8:48 ` Michal Simek
2021-01-22 20:32   ` Daniel Walker (danielwa)
2021-01-25  7:52     ` Michal Simek
2021-01-25 21:04       ` Daniel Walker (danielwa) [this message]
2021-01-26  9:16         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125210419.GU3710@zorba \
    --to=danielwa@cisco.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dwalker@fifo99.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).