* [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
@ 2021-01-15 20:24 Philip Chen
2021-01-15 20:34 ` Stephen Boyd
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philip Chen @ 2021-01-15 20:24 UTC (permalink / raw)
To: LKML, dmitry.torokhov
Cc: swboyd, dianders, Philip Chen, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck, Rob Herring, Simon Glass,
devicetree, linux-input
Add a new property `function-row-physmap` to the
device tree for the custom keyboard top row design.
The property describes the rows/columns of the top row keys
from left to right.
Signed-off-by: Philip Chen <philipchen@chromium.org>
---
Changes in v7:
- Use MATRIX_KEY macro to describe `function-row-physmap`
Changes in v6:
- remove $ref and add `function-row-physmap` to the example
Changes in v5:
- add minItems and maxItems for `function-row-physmap`
Changes in v2:
- add `function-row-physmap` instead of `google,custom-keyb-top-row`
.../bindings/input/google,cros-ec-keyb.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
index 8e50c14a9d778..5377b232fa10f 100644
--- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
+++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
@@ -31,6 +31,17 @@ properties:
if the EC does not have its own logic or hardware for this.
type: boolean
+ function-row-physmap:
+ minItems: 1
+ maxItems: 15
+ description: |
+ An ordered u32 array describing the rows/columns (in the scan matrix)
+ of top row keys from physical left (KEY_F1) to right. Each entry
+ encodes the row/column as:
+ (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
+ where the lower 16 bits are reserved. This property is specified only
+ when the keyboard has a custom design for the top row keys.
+
required:
- compatible
@@ -38,11 +49,24 @@ unevaluatedProperties: false
examples:
- |
+ #include <dt-bindings/input/input.h>
cros-ec-keyb {
compatible = "google,cros-ec-keyb";
keypad,num-rows = <8>;
keypad,num-columns = <13>;
google,needs-ghost-filter;
+ function-row-physmap = <
+ MATRIX_KEY(0x00, 0x02, 0) /* T1 */
+ MATRIX_KEY(0x03, 0x02, 0) /* T2 */
+ MATRIX_KEY(0x02, 0x02, 0) /* T3 */
+ MATRIX_KEY(0x01, 0x02, 0) /* T4 */
+ MATRIX_KEY(0x03, 0x04, 0) /* T5 */
+ MATRIX_KEY(0x02, 0x04, 0) /* T6 */
+ MATRIX_KEY(0x01, 0x04, 0) /* T7 */
+ MATRIX_KEY(0x02, 0x09, 0) /* T8 */
+ MATRIX_KEY(0x01, 0x09, 0) /* T9 */
+ MATRIX_KEY(0x00, 0x04, 0) /* T10 */
+ >;
/*
* Keymap entries take the form of 0xRRCCKKKK where
* RR=Row CC=Column KKKK=Key Code
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
2021-01-15 20:24 [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
@ 2021-01-15 20:34 ` Stephen Boyd
2021-01-25 23:15 ` Rob Herring
2021-02-23 5:07 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-01-15 20:34 UTC (permalink / raw)
To: LKML, Philip Chen, dmitry.torokhov
Cc: dianders, Philip Chen, Benson Leung, Enric Balletbo i Serra,
Guenter Roeck, Rob Herring, Simon Glass, devicetree, linux-input
Quoting Philip Chen (2021-01-15 12:24:29)
> Add a new property `function-row-physmap` to the
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
2021-01-15 20:24 [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-15 20:34 ` Stephen Boyd
@ 2021-01-25 23:15 ` Rob Herring
2021-02-23 5:07 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-01-25 23:15 UTC (permalink / raw)
To: Philip Chen
Cc: devicetree, Guenter Roeck, swboyd, linux-input, dianders,
Simon Glass, Rob Herring, Benson Leung, dmitry.torokhov, LKML,
Enric Balletbo i Serra
On Fri, 15 Jan 2021 12:24:29 -0800, Philip Chen wrote:
> Add a new property `function-row-physmap` to the
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> ---
>
> Changes in v7:
> - Use MATRIX_KEY macro to describe `function-row-physmap`
>
> Changes in v6:
> - remove $ref and add `function-row-physmap` to the example
>
> Changes in v5:
> - add minItems and maxItems for `function-row-physmap`
>
> Changes in v2:
> - add `function-row-physmap` instead of `google,custom-keyb-top-row`
>
> .../bindings/input/google,cros-ec-keyb.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
2021-01-15 20:24 [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-15 20:34 ` Stephen Boyd
2021-01-25 23:15 ` Rob Herring
@ 2021-02-23 5:07 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2021-02-23 5:07 UTC (permalink / raw)
To: Philip Chen
Cc: LKML, swboyd, dianders, Benson Leung, Enric Balletbo i Serra,
Guenter Roeck, Rob Herring, Simon Glass, devicetree, linux-input
On Fri, Jan 15, 2021 at 12:24:29PM -0800, Philip Chen wrote:
> Add a new property `function-row-physmap` to the
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-23 5:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-15 20:24 [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-15 20:34 ` Stephen Boyd
2021-01-25 23:15 ` Rob Herring
2021-02-23 5:07 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).