From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887B5C433E6 for ; Wed, 27 Jan 2021 12:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F7092079A for ; Wed, 27 Jan 2021 12:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238019AbhA0MyY (ORCPT ); Wed, 27 Jan 2021 07:54:24 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:35053 "EHLO mail-wr1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234782AbhA0MwT (ORCPT ); Wed, 27 Jan 2021 07:52:19 -0500 Received: by mail-wr1-f45.google.com with SMTP id l12so1795786wry.2; Wed, 27 Jan 2021 04:52:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eep+yX5nS9Zv3tlSfcqFpACtAupgm1wYpbubdt6K9g0=; b=nNguOsnQtiqvn2OnR/H6NoAjPgnkVGjkOOannCG0QxgEbEkumuBPUIwCyw+AyWajem Ru5+/FuU56dP0nnlTfsaI+gsDjPHWjtzb97p+3e3gbTh4zU7sdnK+T5sz64VUpeZdTtV U507/oKS3iZBr7+VbWnMd1+zGpBrLJS2sbOzj8JvmpWqswrPFaZW8qRmZzENhgftikMQ ztgtVszHb2e7eBq1DHIVmSuGO6d3hisnoFKiJhBJZmgazQLHHkGhdYrbuo76VxMtLRh+ TymE/bEjaFkAg8fdccyYPBQzRfQJ2geIzI7QeP/tzrohxbWelhSl7cxWq3iry3cWUJVF nV8A== X-Gm-Message-State: AOAM533Vm6V2+jhb8c/rzy/GX/4LIHQ5WZBqztySZpyBo3/5NXWo2A7d jNAEnHedHarGjcVHTcdKm5Q= X-Google-Smtp-Source: ABdhPJy6RiCp2ffofk31+hEQz8hRtSY7kQ/q07MYumVyqb85lSkxjUd+OtMe5olevzKLmepAQLSY1w== X-Received: by 2002:a5d:6a85:: with SMTP id s5mr10681043wru.283.1611751896688; Wed, 27 Jan 2021 04:51:36 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id z18sm2919123wro.91.2021.01.27.04.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 04:51:35 -0800 (PST) Date: Wed, 27 Jan 2021 13:51:34 +0100 From: Krzysztof Kozlowski To: Sakari Ailus Cc: Mauro Carvalho Chehab , Rob Herring , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v6 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20210127125134.aayb2xb4lcl4ekn5@kozik-lap> References: <20201118202715.6692-1-krzk@kernel.org> <20210122091822.GB27155@paasikivi.fi.intel.com> <20210127122612.evk5sooijid3dmzd@kozik-lap> <20210127124553.GB32460@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210127124553.GB32460@paasikivi.fi.intel.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jan 27, 2021 at 02:45:53PM +0200, Sakari Ailus wrote: > On Wed, Jan 27, 2021 at 01:26:12PM +0100, Krzysztof Kozlowski wrote: > > On Fri, Jan 22, 2021 at 11:18:22AM +0200, Sakari Ailus wrote: > > > Hi Krysztof, > > > > > > On Wed, Nov 18, 2020 at 09:27:12PM +0100, Krzysztof Kozlowski wrote: > > > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > > > driver, are quite limited, e.g. do not support regulator supplies. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Rob Herring > > > > > > > > --- > > > > > > > > Changes since v4: > > > > 1. Add clock-lanes, > > > > 2. Add Rob's review, > > > > 3. Add one more example and extend existing one, > > > > 4. Add common clock properties (assigned-*). > > > > > > > > Changes since v3: > > > > 1. Document also two lane setup. > > > > > > > > Changes since v2: > > > > 1. Remove clock-frequency, add reset GPIOs, add supplies. > > > > 2. Use additionalProperties. > > > > > > > > Changes since v1: > > > > 1. None > > > > --- > > > > .../devicetree/bindings/media/i2c/imx258.yaml | 140 ++++++++++++++++++ > > > > MAINTAINERS | 1 + > > > > 2 files changed, 141 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > > new file mode 100644 > > > > index 000000000000..4a3471fb88a1 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > > @@ -0,0 +1,140 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > > > > + > > > > +maintainers: > > > > + - Krzysztof Kozlowski > > > > + > > > > +description: |- > > > > + IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > > > > + type stacked image sensor with a square pixel array of size 4208 x 3120. It > > > > + is programmable through I2C interface. Image data is sent through MIPI > > > > + CSI-2. > > > > + > > > > +properties: > > > > + compatible: > > > > + const: sony,imx258 > > > > + > > > > + assigned-clocks: true > > > > + assigned-clock-parents: true > > > > + assigned-clock-rates: true > > > > + > > > > + clocks: > > > > + description: > > > > + Clock frequency from 6 to 27 MHz. > > > > + maxItems: 1 > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + reset-gpios: > > > > + description: |- > > > > + Reference to the GPIO connected to the XCLR pin, if any. > > > > + > > > > + vana-supply: > > > > + description: > > > > + Analog voltage (VANA) supply, 2.7 V > > > > + > > > > + vdig-supply: > > > > + description: > > > > + Digital I/O voltage (VDIG) supply, 1.2 V > > > > + > > > > + vif-supply: > > > > + description: > > > > + Interface voltage (VIF) supply, 1.8 V > > > > + > > > > + # See ../video-interfaces.txt for more details > > > > + port: > > > > + type: object > > > > + properties: > > > > + endpoint: > > > > + type: object > > > > + properties: > > > > + clock-lanes: > > > > + const: 0 > > > > > > This is redundant. Please remove, same for the examples. Can be a separate > > > patch, too. > > > > Before I remove too much - you mean "clock-lanes" is redundant or entire > > set of properties in "port" node? > > Just clock-lanes. The rest are just as they should be IMO. Yes, makes sense. Thanks for confirmation. Best regards, Krzysztof