Devicetree
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>, Sekhar Nori <nsekhar@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Rob Herring <robh@kernel.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
Date: Wed, 27 Jan 2021 10:00:59 -0600	[thread overview]
Message-ID: <20210127160059.xob2k57agzzgqaph@always> (raw)
In-Reply-To: <161131973654.21299.8023411678794984222.b4-ty@ti.com>

On 06:49-20210122, Nishanth Menon wrote:
> On Thu, 21 Jan 2021 11:33:05 +0530, Lokesh Vutla wrote:
> > With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
> > like below for all interrupt controllers.
> > 
> > /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
> > 
> > Fix these by adding #address-cells = <0>; for all interrupt controllers in
> > TI device-tree files. Any other #address-cells value is really only needed
> > if interrupt-map property is being used (which is not the case for existing
> > TI device-tree files)
> 
> Hi Lokesh Vutla,
> 
> I have applied the following to branch ti-k3-next on [1].
> Thank you!
> 
> [1/1] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
>       commit: 73d0af633c4bed02f8e71658c9e25ac8250b08c4
> 
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent up the chain during
> the next merge window (or sooner if it is a relevant bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
[...]

Lokesh,

Based on discussion on [1] - looks like #address-cells = 0 usage
is still to be resolved and needs some alignment between Andre and
Rob on where to take this (dtc fixups to handle this Vs explicit
#address-cells = 0 and increase in dtb size).

I propose we drop this patch rather than having to revert this at a
later point after I send a PR. Anyone has any objections?

[1] https://lore.kernel.org/linux-arm-kernel/20210126163839.57491132@slackpad.fritz.box/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

      reply	other threads:[~2021-01-27 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  6:03 [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller Lokesh Vutla
2021-01-22 12:49 ` Nishanth Menon
2021-01-27 16:00   ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127160059.xob2k57agzzgqaph@always \
    --to=nm@ti.com \
    --cc=andre.przywara@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lokeshvutla@ti.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox