From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836A1C433E6 for ; Thu, 28 Jan 2021 04:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 401F064DD8 for ; Thu, 28 Jan 2021 04:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbhA1EXr (ORCPT ); Wed, 27 Jan 2021 23:23:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbhA1EXf (ORCPT ); Wed, 27 Jan 2021 23:23:35 -0500 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26FBEC061574 for ; Wed, 27 Jan 2021 20:22:55 -0800 (PST) Received: by mail-oi1-x233.google.com with SMTP id w8so4733680oie.2 for ; Wed, 27 Jan 2021 20:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O1OjT8zIKlV0ZCK1tBM/DkEt2nDZlUgna8AxTAM0HjE=; b=Kute2u9nsOXwFp7yoluyqjOpEwyICfdIVWIS0bmcpqcvuEO0TqjS2oDd+rAOZC5Kdo v72SJ/MfQiZ4Laf6LckSXyvFegjMVC+kuqplV8vmtsWV3BymP1RFwk3wuSfeg+tdUOkf hlnxHmwqqQcMKrbudy23DY6US5Rwbyd9YmX5gNQZYhE+NEWo3UpoVy1rK6CE04NNYT+2 bWZZAx1H9uxfzl1F7JWVV+vO5NmK1BsXRy0qOzQY7oPV/PR9+gTHieI3zcfxfr6b86zZ w1HJrQfzMBLPi3PlIXedtQC772RWefPtf2Z11YBLYl8dE0LCAI6X4AjeD/TYloj00yDD zNkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O1OjT8zIKlV0ZCK1tBM/DkEt2nDZlUgna8AxTAM0HjE=; b=GOhAGf4tLGlgwB/IZY7F2o92ceAvGLQZBZRQU3JealHevtzwNnUFmuUUMnfxPrH4ah mHy8B1+3V8n5ICQEFuYswx8T84xIKsegwcCl/S/wDcT81cMBrT4Fk+q/qDQCzm5I7AW5 iqxM91GWErbILpzCEBtQWozKBfgClxqLI0cJyqE5X80OAm//EhMAhx6Jr4QhxfEEStH3 VbyC8JZpITR6aQcQJZV1jbf5pshOsXb10JQlOXrD0k8SZGHmPJR8SdiMYnKSy3Pwqpht XBcxX6fV64jqYP84H01HmtXGwmKTSTgDk7MupD+uZmM8r7NAQWrZ0I805JKWgTfAl672 v/4Q== X-Gm-Message-State: AOAM533Wa7e20DDtm6leg6WW3hLKbkzwwIaDDnR9FEeIQDLY9FZE6Sr9 2iV6VbczmVVfii/z2t8kkylZaQ== X-Google-Smtp-Source: ABdhPJz9/+9CU1uj1vWZJogbcLUZnsFAExsfO+xUQunSfrn5WvbV3SPtE5ZB+Pl2GMuzS5qKZvkXEA== X-Received: by 2002:a05:6808:213:: with SMTP id l19mr5244420oie.83.1611807774569; Wed, 27 Jan 2021 20:22:54 -0800 (PST) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a22sm785048otp.53.2021.01.27.20.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 20:22:53 -0800 (PST) Date: Wed, 27 Jan 2021 22:22:51 -0600 From: Bjorn Andersson To: Jonathan Albrieux Cc: Stephan Gerhold , Konrad Dybcio , linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer Message-ID: <20210128042251.GB5254@yoga> References: <20210124135409.5473-1-jonathan.albrieux@gmail.com> <20210124135409.5473-4-jonathan.albrieux@gmail.com> <20210124194927.GA4448@jonathan-N53SV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210124194927.GA4448@jonathan-N53SV> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun 24 Jan 13:49 CST 2021, Jonathan Albrieux wrote: > On Sun, Jan 24, 2021 at 04:51:31PM +0100, Stephan Gerhold wrote: > > On Sun, Jan 24, 2021 at 04:07:19PM +0100, Konrad Dybcio wrote: > > > > +&blsp_i2c3 { > > > > + status = "okay"; > > > > + > > > > + imu@68 { > > > > + compatible = "bosch,bmi160"; > > > > + reg = <0x68>; > > > > + > > > > + vdd-supply = <&pm8916_l17>; > > > > + vddio-supply = <&pm8916_l6>; > > > > + > > > > + mount-matrix = "0", "1", "0", > > > > + "-1", "0", "0", > > > > + "0", "0", "1"; > > > > + }; > > > > + > > > > + magnetometer@d { > > > > + compatible = "asahi-kasei,ak09911"; > > > > + reg = <0x0d>; > > > > + > > > > + vdd-supply = <&pm8916_l17>; > > > > + vid-supply = <&pm8916_l6>; > > > > + > > > > + reset-gpios = <&msmgpio 111 GPIO_ACTIVE_LOW>; > > > > + > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&mag_reset_default>; > > > > + }; > > > > +}; > > > > > > Please sort I2C devices by their address. > > > > > > > +1 :) > > > Thank you Konrad, thank you Stephan, I'll fix the order! > > > > > > > > }; > > > > > > > > + mag_reset_default: mag-reset-default { > > > > + pins = "gpio111"; > > > > + function = "gpio"; > > > > + > > > > + drive-strength = <2>; > > > > + bias-disable; > > > > + }; > > > > + > > > > > > Please add this after gpio110 to keep it sorted gpio-number-wise. > > > > > > > This is ordered alphabetically. I haven't seen gpio-number order > > anywhere yet... :) > > > Let me know if this order has to be changed, meanwhile I'll prepare > a v2 for the i2c device order and will prepare a v3 in case this > order too has to be changed. > I'm happy with having these sorted alphabetically. Regards, Bjorn