devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org,
	Atish Patra <atish.patra@wdc.com>,
	Anup Patel <anup.patel@wdc.com>,
	Sean Anderson <seanga2@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v15 02/16] dt-bindings: add Canaan boards compatible strings
Date: Thu, 4 Feb 2021 17:46:01 -0600	[thread overview]
Message-ID: <20210204234601.GA1340444@robh.at.kernel.org> (raw)
In-Reply-To: <20210203125913.390949-3-damien.lemoal@wdc.com>

On Wed, Feb 03, 2021 at 09:58:59PM +0900, Damien Le Moal wrote:
> Introduce the file riscv/canaan.yaml to document compatible strings
> related to the Canaan Kendryte K210 SoC. The compatible string
> "canaan,kendryte-k210" used to indicate the use of this SoC to the
> early SoC init code is added. This new file also defines the compatible
> strings of all supported boards based on this SoC.
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Reviewed-by: Atish Patra <atish.patra@wdc.com>
> ---
>  .../devicetree/bindings/riscv/canaan.yaml     | 47 +++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/riscv/canaan.yaml
> 
> diff --git a/Documentation/devicetree/bindings/riscv/canaan.yaml b/Documentation/devicetree/bindings/riscv/canaan.yaml
> new file mode 100644
> index 000000000000..f8f3f286bd55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/canaan.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/canaan.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Canaan SoC-based boards
> +
> +maintainers:
> +  - Damien Le Moal <damien.lemoal@wdc.com>
> +
> +description:
> +  Canaan Kendryte K210 SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: sipeed,maix-bit
> +          - const: sipeed,maix-bitm
> +          - const: canaan,kendryte-k210
> +
> +      - items:
> +          - const: sipeed,maix-go
> +          - const: canaan,kendryte-k210
> +
> +      - items:
> +          - const: sipeed,maix-dock-m1
> +          - const: sipeed,maix-dock-m1w
> +          - const: canaan,kendryte-k210
> +
> +      - items:
> +          - const: sipeed,maixduino
> +          - const: canaan,kendryte-k210
> +
> +      - items:
> +          - const: canaan,kendryte-kd233
> +          - const: canaan,kendryte-k210

You could combine all the 2 entry cases. Some boards do this form though 
to add a description on each one. Either way,

Reviewed-by: Rob Herring <robh@kernel.org>

> +
> +      - items:
> +          - const: canaan,kendryte-k210
> +
> +additionalProperties: true
> +
> +...
> -- 
> 2.29.2
> 

  reply	other threads:[~2021-02-04 23:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210203125913.390949-1-damien.lemoal@wdc.com>
2021-02-03 12:58 ` [PATCH v15 02/16] dt-bindings: add Canaan boards compatible strings Damien Le Moal
2021-02-04 23:46   ` Rob Herring [this message]
2021-02-03 12:59 ` [PATCH v15 03/16] dt-bindings: update risc-v cpu properties Damien Le Moal
2021-02-05  4:34   ` Anup Patel
2021-02-03 12:59 ` [PATCH v15 04/16] dt-bindings: update sifive plic compatible string Damien Le Moal
2021-02-04 23:48   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 05/16] dt-bindings: update sifive clint " Damien Le Moal
2021-02-04 23:49   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 06/16] dt-bindings: update sifive uart " Damien Le Moal
2021-02-04 23:49   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 07/16] dt-bindings: fix sifive gpio properties Damien Le Moal
2021-02-03 18:02   ` Atish Patra
2021-02-03 12:59 ` [PATCH v15 08/16] dt-bindings: add resets property to dw-apb-timer Damien Le Moal
2021-02-04 23:49   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 09/16] riscv: Update Canaan Kendryte K210 device tree Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 10/16] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 11/16] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 12/16] riscv: Add SiPeed MAIX GO " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 13/16] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 14/16] riscv: Add Kendryte KD233 " Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204234601.GA1340444@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=anup.patel@wdc.com \
    --cc=atish.patra@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=seanga2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).