devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org,
	Atish Patra <atish.patra@wdc.com>,
	Anup Patel <anup.patel@wdc.com>,
	Sean Anderson <seanga2@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v15 05/16] dt-bindings: update sifive clint compatible string
Date: Thu, 4 Feb 2021 17:49:09 -0600	[thread overview]
Message-ID: <20210204234909.GA1351854@robh.at.kernel.org> (raw)
In-Reply-To: <20210203125913.390949-6-damien.lemoal@wdc.com>

On Wed, Feb 03, 2021 at 09:59:02PM +0900, Damien Le Moal wrote:
> Add the "canaan,k210-clint" compatible string to the Sifive clint
> bindings to indicate the use of the "sifive,clint0" IP block in the
> Canaan Kendryte K210 SoC. The description of the compatible string
> property is also updated to reflect this addition.
> 
> Cc: Anup Patel <anup.patel@wdc.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Reviewed-by: Atish Patra <atish.patra@wdc.com>
> ---
>  .../bindings/timer/sifive,clint.yaml          | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index 2a0e9cd9fbcf..1a7d582a208f 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -22,16 +22,23 @@ description:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: sifive,fu540-c000-clint

Use enum here too.

> -      - const: sifive,clint0
> +    oneOf:
> +      - items:
> +          - const: sifive,fu540-c000-clint
> +          - const: sifive,clint0
> +
> +      - items:
> +          - const: canaan,k210-clint
> +          - const: sifive,clint0
>  
>      description:
> -      Should be "sifive,<chip>-clint" and "sifive,clint<version>".
> +      Should be "<vendor>,<chip>-clint" and "sifive,clint<version>".
>        Supported compatible strings are -
>        "sifive,fu540-c000-clint" for the SiFive CLINT v0 as integrated
> -      onto the SiFive FU540 chip, and "sifive,clint0" for the SiFive
> -      CLINT v0 IP block with no chip integration tweaks.
> +      onto the SiFive FU540 chip, "canaan,k210-clint" for the SiFive
> +      CLINT v0 as integrated onto the Canaan Kendryte K210 chip, and
> +      "sifive,clint0" for the SiFive CLINT v0 IP block with no chip
> +      integration tweaks.
>        Please refer to sifive-blocks-ip-versioning.txt for details
>  
>    reg:
> -- 
> 2.29.2
> 

  reply	other threads:[~2021-02-04 23:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210203125913.390949-1-damien.lemoal@wdc.com>
2021-02-03 12:58 ` [PATCH v15 02/16] dt-bindings: add Canaan boards compatible strings Damien Le Moal
2021-02-04 23:46   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 03/16] dt-bindings: update risc-v cpu properties Damien Le Moal
2021-02-05  4:34   ` Anup Patel
2021-02-03 12:59 ` [PATCH v15 04/16] dt-bindings: update sifive plic compatible string Damien Le Moal
2021-02-04 23:48   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 05/16] dt-bindings: update sifive clint " Damien Le Moal
2021-02-04 23:49   ` Rob Herring [this message]
2021-02-03 12:59 ` [PATCH v15 06/16] dt-bindings: update sifive uart " Damien Le Moal
2021-02-04 23:49   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 07/16] dt-bindings: fix sifive gpio properties Damien Le Moal
2021-02-03 18:02   ` Atish Patra
2021-02-03 12:59 ` [PATCH v15 08/16] dt-bindings: add resets property to dw-apb-timer Damien Le Moal
2021-02-04 23:49   ` Rob Herring
2021-02-03 12:59 ` [PATCH v15 09/16] riscv: Update Canaan Kendryte K210 device tree Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 10/16] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 11/16] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 12/16] riscv: Add SiPeed MAIX GO " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 13/16] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2021-02-03 12:59 ` [PATCH v15 14/16] riscv: Add Kendryte KD233 " Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204234909.GA1351854@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=anup.patel@wdc.com \
    --cc=atish.patra@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=seanga2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).