From: Pavel Machek <pavel@ucw.cz>
To: Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT
Date: Fri, 5 Feb 2021 11:23:38 +0100 [thread overview]
Message-ID: <20210205102338.GA27854@amd> (raw)
In-Reply-To: <DB8P190MB063482D8E38C0529AD16A4D5D9B29@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
Hi!
> > > patternProperties:
> > > "(^led-[0-9a-f]$|led)":
> > > @@ -99,6 +104,7 @@ examples:
> > > reg = <0x1>;
> > > color = <LED_COLOR_ID_RGB>;
> > > function = LED_FUNCTION_CHARGING;
> > > + default-intensity = <100 0 0>;
> > >
> > > led-0 {
> > > color = <LED_COLOR_ID_RED>;
> >
> > Should this go to leds-class-multicolor.yaml ?
>
> I think then all drivers should support it, but I cannot change all drivers.
> So I would only leave it in there.
It really should be in common binding, and no, that does not mean you
need to change all the drivers.
Plus there's at most two of them at the moment.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-05 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:37 [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT Sven Schuchmann
2021-02-04 14:52 ` Pavel Machek
2021-02-05 9:57 ` AW: " Sven Schuchmann
2021-02-05 10:23 ` Pavel Machek [this message]
2021-02-05 18:37 ` Jacek Anaszewski
2021-02-06 13:14 ` AW: " Sven Schuchmann
2021-02-06 20:58 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205102338.GA27854@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).