From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: thierry.reding@gmail.com, broonie@kernel.org,
lgirdwood@gmail.com, kuninori.morimoto.gx@renesas.com,
jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
sharadg@nvidia.com
Subject: Re: [PATCH v2 3/9] ASoC: audio-graph-card: Add clocks property to endpoint node
Date: Fri, 5 Feb 2021 09:26:44 -0600 [thread overview]
Message-ID: <20210205152644.GA3083322@robh.at.kernel.org> (raw)
In-Reply-To: <1611944866-29373-4-git-send-email-spujar@nvidia.com>
On Fri, Jan 29, 2021 at 11:57:40PM +0530, Sameer Pujar wrote:
> Add optional 'clocks' property to audio port 'endpoint' node. One
> such example is where SoC supplies a clock to external audio codec
> component.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 766e910..08ed8f5 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -33,6 +33,9 @@ properties:
> properties:
> remote-endpoint:
> maxItems: 1
> + clocks:
> + maxItems: 1
> + description: Describes the clock used by audio component.
NAK
An endpoint is not a device. Clocks go with a device.
> mclk-fs:
> description: |
> Multiplication factor between stream rate and codec mclk.
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-02-05 22:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:27 [PATCH v2 0/9] Tegra186 and Tegra194 audio graph card Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 1/9] ASoC: dt-bindings: rt5659: Update binding doc Sameer Pujar
2021-02-05 15:29 ` Rob Herring
2021-02-09 13:21 ` Sameer Pujar
2021-02-09 19:19 ` Thierry Reding
2021-02-10 6:58 ` Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 2/9] ASoC: dt-bindings: tegra: Add iommus property to Tegra graph card Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 3/9] ASoC: audio-graph-card: Add clocks property to endpoint node Sameer Pujar
2021-02-05 15:26 ` Rob Herring [this message]
2021-02-09 13:18 ` Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 4/9] ASoC: rt5659: Add Kconfig prompt Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 5/9] arm64: defconfig: Enable RT5659 Sameer Pujar
2021-02-03 10:00 ` Jon Hunter
2021-01-29 18:27 ` [PATCH v2 6/9] arm64: tegra: Add RT5658 device entry Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 7/9] Revert "arm64: tegra: Disable the ACONNECT for Jetson TX2" Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 8/9] arm64: tegra: Audio graph sound card for Jetson TX2 Sameer Pujar
2021-01-29 18:27 ` [PATCH v2 9/9] arm64: tegra: Audio graph sound card for Jetson AGX Xavier Sameer Pujar
2021-02-01 16:45 ` (subset) [PATCH v2 0/9] Tegra186 and Tegra194 audio graph card Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205152644.GA3083322@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).