Re: [PATCH 21/24] dt-bindings:iio:cdc:adi,ad7150 binding doc

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 7 Feb 2021 17:00:24 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:

> On 2/7/21 4:46 PM, Jonathan Cameron wrote:
> > +required:
> > +  - compatible
> > +  - reg  
> 
> Is vdd-supply really optional the way it is implemented in the driver?

Well sort of.  Obviously VDD isn't optional in the sense that the
device needs power, but it is in the binding because a stub regulator
should be fine.  For those regulator_enable() is a noop on assumption
they are already on.

> 
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        cdc@48 {
> > +            compatible = "adi,ad7150";
> > +            reg = <0x48>;
> > +            interrupts = <25 2>, <26 2>;  
> 
> I wonder if we should use the symbolic constants for the IRQ type to 
> make the example more clear. E.g.
> 
> interrupts = <25 IRQ_TYPE_EDGE_FALLING>, ...

Sure. I'll update in v2.

> 
> > +            interrupt-parent = <&gpio>;
> > +        };
> > +    };
> > +...  
> 
>