Re: [PATCH 4/5] arm64: dts: librem5: protect some partitions of the nor-flash

Krzysztof Kozlowski
2021-02-08T14:13:48Z

On Mon, Feb 08, 2021 at 02:15:26PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <angus@akkea.ca>
>
> These sections should be read only as they contain important data.
>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..9867e2a50008 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;

One empty line here.

> + partition@0x00000000 {

Wrong unit names. Compile dtses with W=1.

> + label = "protected0";
> + reg = <0x00000000 0x00030000>;

Get rid of leading 0000 - it makes it less readable.

Best regards,
Krzysztof