From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB27C433E6 for ; Mon, 8 Feb 2021 18:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2411664E8C for ; Mon, 8 Feb 2021 18:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234282AbhBHSNz (ORCPT ); Mon, 8 Feb 2021 13:13:55 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:44351 "EHLO mail-wr1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235580AbhBHSNe (ORCPT ); Mon, 8 Feb 2021 13:13:34 -0500 Received: by mail-wr1-f42.google.com with SMTP id g6so5342820wrs.11; Mon, 08 Feb 2021 10:13:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uG44Nh0+1Z6GPKJ+sMh7UFsXf5L8CgK5m4MwsqTm8vM=; b=jIf9VlxY9qXAESIYVVQ8yyiks4N/dz0BJYlqXZAY90rGLWxOuuJPRU5t5THsiZKqdS Oj1UpgZAgcVpMCPPqC27LDAMyLxIKZl4s9qwaKL/2o9o6mfU3ByQ16PqT8voF/KtHNHy eCStGUm0p2ItUrO55oRDLmfWQeBawSqDHq9GsnFVTwO/GtPNdMeAK/dGoRgjXFF8cbAW WiXKgzH7SNbZie3sTMVJ5RYovCRQCIgg5iFYvUuysEComz05WfapqHZ16hF0/AlDoFgK psjY9mYv81rE36Fk0c6u4rz3ACUoJt6YKrdIbMyVg9Ps5m0gajXNG/AybCmH1bx/7g4G 2dPg== X-Gm-Message-State: AOAM532svuTI3fuV3E1WSVHWuNc2xHTUJi9+nuBlGUOCxPXwcdgS3F72 nWyW3EcGDTEjbo7xN8UqCUI= X-Google-Smtp-Source: ABdhPJy/wKPjP7+LBFoeHW0XLxMt/V+JDUKUXKCYLCJTnC5Yurk6M5a1DiVIEb/R09EmHRvq8ISlSg== X-Received: by 2002:adf:e3cd:: with SMTP id k13mr84116wrm.289.1612807972155; Mon, 08 Feb 2021 10:12:52 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id s23sm21317647wmc.35.2021.02.08.10.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 10:12:49 -0800 (PST) Date: Mon, 8 Feb 2021 19:12:48 +0100 From: Krzysztof Kozlowski To: Rob Herring List-Id: Cc: Hector Martin , Arnd Bergmann , devicetree@vger.kernel.org, Marc Zyngier , linux-kernel@vger.kernel.org, soc@kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/18] dt-bindings: vendor-prefixes: add AAPL prefix Message-ID: <20210208181248.tbgffdwghlseawic@kozik-lap> References: <20210204203951.52105-1-marcan@marcan.st> <20210204203951.52105-2-marcan@marcan.st> <20210208102730.p4nhsl35oowsklv2@kozik-lap> <20210208173215.GA1567700@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210208173215.GA1567700@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Feb 08, 2021 at 11:32:15AM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 11:27:30AM +0100, Krzysztof Kozlowski wrote: > > On Fri, Feb 05, 2021 at 05:39:34AM +0900, Hector Martin wrote: > > > Amusingly, this wasn't yet documented, even though this vendor prefix > > > has been used since time immemorial on PPC. > > > > > > Signed-off-by: Hector Martin > > > --- > > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > index 041ae90b0d8f..d7950c723472 100644 > > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > @@ -25,6 +25,8 @@ patternProperties: > > > # Keep list in alphabetical order. > > > "^70mai,.*": > > > description: 70mai Co., Ltd. > > > + "^AAPL,.*": > > > > All prefixes are lower case... see ABB below (not mentioning that the > > company name is not APPLE), so just "apple". > > Grep the kernel tree for 'AAPL,'. I know it's the ticker, but the point was - we don't use tickers here for none of other platforms. Mentioned grep brings only one result: arch/powerpc/platforms/powermac/pic.c: * cases where the APPL,interrupts property is completely so hardly an argument for backwards consistency, within the kernel. On the other hand, some DTs for iPhones mention "apple", not APPL: https://www.theiphonewiki.com/wiki/D211AP/Device_Tree https://www.theiphonewiki.com/wiki/D331AP/Device_Tree https://gist.github.com/bazad/1faef1a6fe396b820a43170b43e38be1 Although I am not sure how reliable are the sources. > It comes from the the ticker symbol > which early on was the preferred form, but we've tended to move away > from that. The DT Apple ships (which is *very* different) uses both > forms. > > So keep what exists already or have old AAPL and new apple? Hectore mention old PowerPC Apple sources were using the APPL, but it seems they did not end up here. What would be the point to stick to the old prefix if we cannot find it? Maybe they exists in other systems? I could not find such in latest FreeBSD, but there were not many DTSes inside. Best regards, Krzysztof