* [RESEND v3 2/2] drm/bridge: anx7625: disable regulators when power off
2021-02-20 6:08 [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies Hsin-Yi Wang
@ 2021-02-20 6:08 ` Hsin-Yi Wang
2021-02-23 14:59 ` [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies Robert Foss
1 sibling, 0 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-02-20 6:08 UTC (permalink / raw)
To: Xin Ji, David Airlie, dri-devel
Cc: Sam Ravnborg, Rob Herring, Daniel Vetter, devicetree,
linux-kernel, Neil Armstrong, Laurent Pinchart
When suspending the driver, anx7625_power_standby() will be called to
turn off reset-gpios and enable-gpios. However, power supplies are not
disabled. To save power, the driver can get the power supply regulators
and turn off them in anx7625_power_standby().
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Change:
v3: add delays between regulators power on
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 34 +++++++++++++++++++++++
drivers/gpu/drm/bridge/analogix/anx7625.h | 1 +
2 files changed, 35 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc05982f826..23283ba0c4f93 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/slab.h>
#include <linux/types.h>
#include <linux/workqueue.h>
@@ -875,12 +876,25 @@ static int sp_tx_edid_read(struct anx7625_data *ctx,
static void anx7625_power_on(struct anx7625_data *ctx)
{
struct device *dev = &ctx->client->dev;
+ int ret, i;
if (!ctx->pdata.low_power_mode) {
DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n");
return;
}
+ for (i = 0; i < ARRAY_SIZE(ctx->pdata.supplies); i++) {
+ ret = regulator_enable(ctx->pdata.supplies[i].consumer);
+ if (ret < 0) {
+ DRM_DEV_DEBUG_DRIVER(dev, "cannot enable supply %d: %d\n",
+ i, ret);
+ goto reg_err;
+ }
+ usleep_range(2000, 2100);
+ }
+
+ usleep_range(4000, 4100);
+
/* Power on pin enable */
gpiod_set_value(ctx->pdata.gpio_p_on, 1);
usleep_range(10000, 11000);
@@ -889,11 +903,16 @@ static void anx7625_power_on(struct anx7625_data *ctx)
usleep_range(10000, 11000);
DRM_DEV_DEBUG_DRIVER(dev, "power on !\n");
+ return;
+reg_err:
+ for (--i; i >= 0; i--)
+ regulator_disable(ctx->pdata.supplies[i].consumer);
}
static void anx7625_power_standby(struct anx7625_data *ctx)
{
struct device *dev = &ctx->client->dev;
+ int ret;
if (!ctx->pdata.low_power_mode) {
DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n");
@@ -904,6 +923,12 @@ static void anx7625_power_standby(struct anx7625_data *ctx)
usleep_range(1000, 1100);
gpiod_set_value(ctx->pdata.gpio_p_on, 0);
usleep_range(1000, 1100);
+
+ ret = regulator_bulk_disable(ARRAY_SIZE(ctx->pdata.supplies),
+ ctx->pdata.supplies);
+ if (ret < 0)
+ DRM_DEV_DEBUG_DRIVER(dev, "cannot disable supplies %d\n", ret);
+
DRM_DEV_DEBUG_DRIVER(dev, "power down\n");
}
@@ -1742,6 +1767,15 @@ static int anx7625_i2c_probe(struct i2c_client *client,
platform->client = client;
i2c_set_clientdata(client, platform);
+ pdata->supplies[0].supply = "vdd10";
+ pdata->supplies[1].supply = "vdd18";
+ pdata->supplies[2].supply = "vdd33";
+ ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pdata->supplies),
+ pdata->supplies);
+ if (ret) {
+ DRM_DEV_ERROR(dev, "fail to get power supplies: %d\n", ret);
+ return ret;
+ }
anx7625_init_gpio(platform);
atomic_set(&platform->power_status, 0);
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h
index 193ad86c54503..e4a086b3a3d7b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.h
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.h
@@ -350,6 +350,7 @@ struct s_edid_data {
struct anx7625_platform_data {
struct gpio_desc *gpio_p_on;
struct gpio_desc *gpio_reset;
+ struct regulator_bulk_data supplies[3];
struct drm_bridge *panel_bridge;
int intp_irq;
u32 low_power_mode;
--
2.30.0.617.g56c4b15f3c-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies
2021-02-20 6:08 [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies Hsin-Yi Wang
2021-02-20 6:08 ` [RESEND v3 2/2] drm/bridge: anx7625: disable regulators when power off Hsin-Yi Wang
@ 2021-02-23 14:59 ` Robert Foss
1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2021-02-23 14:59 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Xin Ji, David Airlie, dri-devel, Sam Ravnborg, Rob Herring,
Daniel Vetter,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Neil Armstrong, Laurent Pinchart
Hey Hsin-Yi,
Thanks for the patch, and sorry about the delays in reviewing this.
This patch does not apply to the drm-misc/for-linux-next branch due to
some other changes having been merged.
On Sat, 20 Feb 2021 at 07:10, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> anx7625 requires 3 power supply regulators.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 60585a4fc22bc..3ae97d9523e56 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -34,6 +34,15 @@ properties:
> description: used for reset chip control, RESET_N pin B7.
> maxItems: 1
>
> + vdd10-supply:
> + description: Regulator that provides the supply 1.0V power.
> +
> + vdd18-supply:
> + description: Regulator that provides the supply 1.8V power.
> +
> + vdd33-supply:
> + description: Regulator that provides the supply 3.3V power.
> +
This chunk below has seen some changes.
With this patch fixed, feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
> ports:
> type: object
>
> @@ -55,6 +64,9 @@ properties:
> required:
> - compatible
> - reg
> + - vdd10-supply
> + - vdd18-supply
> + - vdd33-supply
> - ports
>
> additionalProperties: false
> @@ -72,6 +84,9 @@ examples:
> reg = <0x58>;
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> + vdd10-supply = <&pp1000_mipibrdg>;
> + vdd18-supply = <&pp1800_mipibrdg>;
> + vdd33-supply = <&pp3300_mipibrdg>;
>
> ports {
> #address-cells = <1>;
> --
> 2.30.0.617.g56c4b15f3c-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread