From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3353C433E6 for ; Sat, 20 Feb 2021 06:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B09964E44 for ; Sat, 20 Feb 2021 06:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhBTGJE (ORCPT ); Sat, 20 Feb 2021 01:09:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbhBTGJA (ORCPT ); Sat, 20 Feb 2021 01:09:00 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E11F3C06178C for ; Fri, 19 Feb 2021 22:08:19 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id q20so3283345pfu.8 for ; Fri, 19 Feb 2021 22:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e6H0vIyJ02JtJQR7yExVBxVczRblZOa+3EfhTLKjQOc=; b=KOwQB5Ln07mnRQn0VVBDY7Su6Qe78dbZZsxHc80eg3lrR6jNVuGjFlIZffY1V0+8PT DWWiXNVy75rHSL6Rh6XbG10SSkv8E2srtMGreqQg3VDRHPAXZj0n3vfsi8Zt2llae8D5 gt3vmMfJgXKiJXCKcAlO2AHLpw3UYMwb2RTX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e6H0vIyJ02JtJQR7yExVBxVczRblZOa+3EfhTLKjQOc=; b=BqKH8TP/ChllH9fN5r8AnRX/6riTXE3QAv5OtZW+NGxYJRXNw4skhXWvnsGOFSRWNM aANajVKeSyAbi5w9ZRiRLjs26U2Uo8gg2xurTuV12qTxLEnktMIi5dWohZQQiYAP/WwG ptVHfC1yMex/ReoAduPHZmGbySrOJl7Mmq47d2RYGBSt0lJUT3dBpa0qDkcaxqKL9GsW N54F10mD4B9BbjCBIOZE6XtTtI4L814YU32Wrun0RLY57e3QUP33qYH5sh/d+nCZRPBy P2K+SN7x/Z0izy3T0dKahN8gpRDaHfix5ZNKpXQpU3OVrG8SfTla9vLSSJsKNp/QyFfr 5f5w== X-Gm-Message-State: AOAM533A1IkLCo0awxr0frY8MCbKd1InO6Q2UAm6LiS3IbUIHYghPbsJ 9YcCZ60C2uOwYbvrfF7YVxg1YA== X-Google-Smtp-Source: ABdhPJwypyymS2xVuiv8T2DQ59bYm3LPH70kPJr0h0taKwARkMRdR1iKIn6ooDUpAmNO4Prty9xUag== X-Received: by 2002:a63:155b:: with SMTP id 27mr11245526pgv.269.1613801299402; Fri, 19 Feb 2021 22:08:19 -0800 (PST) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:537:d36b:e4d6:54fb]) by smtp.gmail.com with ESMTPSA id w187sm10943697pfb.208.2021.02.19.22.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 22:08:19 -0800 (PST) From: Hsin-Yi Wang To: Xin Ji , David Airlie , dri-devel@lists.freedesktop.org Cc: Sam Ravnborg , Rob Herring , Daniel Vetter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Laurent Pinchart Subject: [RESEND v3 2/2] drm/bridge: anx7625: disable regulators when power off Date: Sat, 20 Feb 2021 14:08:11 +0800 Message-Id: <20210220060811.2500081-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog In-Reply-To: <20210220060811.2500081-1-hsinyi@chromium.org> References: <20210220060811.2500081-1-hsinyi@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When suspending the driver, anx7625_power_standby() will be called to turn off reset-gpios and enable-gpios. However, power supplies are not disabled. To save power, the driver can get the power supply regulators and turn off them in anx7625_power_standby(). Signed-off-by: Hsin-Yi Wang --- Change: v3: add delays between regulators power on --- drivers/gpu/drm/bridge/analogix/anx7625.c | 34 +++++++++++++++++++++++ drivers/gpu/drm/bridge/analogix/anx7625.h | 1 + 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 65cc05982f826..23283ba0c4f93 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -875,12 +876,25 @@ static int sp_tx_edid_read(struct anx7625_data *ctx, static void anx7625_power_on(struct anx7625_data *ctx) { struct device *dev = &ctx->client->dev; + int ret, i; if (!ctx->pdata.low_power_mode) { DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n"); return; } + for (i = 0; i < ARRAY_SIZE(ctx->pdata.supplies); i++) { + ret = regulator_enable(ctx->pdata.supplies[i].consumer); + if (ret < 0) { + DRM_DEV_DEBUG_DRIVER(dev, "cannot enable supply %d: %d\n", + i, ret); + goto reg_err; + } + usleep_range(2000, 2100); + } + + usleep_range(4000, 4100); + /* Power on pin enable */ gpiod_set_value(ctx->pdata.gpio_p_on, 1); usleep_range(10000, 11000); @@ -889,11 +903,16 @@ static void anx7625_power_on(struct anx7625_data *ctx) usleep_range(10000, 11000); DRM_DEV_DEBUG_DRIVER(dev, "power on !\n"); + return; +reg_err: + for (--i; i >= 0; i--) + regulator_disable(ctx->pdata.supplies[i].consumer); } static void anx7625_power_standby(struct anx7625_data *ctx) { struct device *dev = &ctx->client->dev; + int ret; if (!ctx->pdata.low_power_mode) { DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n"); @@ -904,6 +923,12 @@ static void anx7625_power_standby(struct anx7625_data *ctx) usleep_range(1000, 1100); gpiod_set_value(ctx->pdata.gpio_p_on, 0); usleep_range(1000, 1100); + + ret = regulator_bulk_disable(ARRAY_SIZE(ctx->pdata.supplies), + ctx->pdata.supplies); + if (ret < 0) + DRM_DEV_DEBUG_DRIVER(dev, "cannot disable supplies %d\n", ret); + DRM_DEV_DEBUG_DRIVER(dev, "power down\n"); } @@ -1742,6 +1767,15 @@ static int anx7625_i2c_probe(struct i2c_client *client, platform->client = client; i2c_set_clientdata(client, platform); + pdata->supplies[0].supply = "vdd10"; + pdata->supplies[1].supply = "vdd18"; + pdata->supplies[2].supply = "vdd33"; + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pdata->supplies), + pdata->supplies); + if (ret) { + DRM_DEV_ERROR(dev, "fail to get power supplies: %d\n", ret); + return ret; + } anx7625_init_gpio(platform); atomic_set(&platform->power_status, 0); diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h index 193ad86c54503..e4a086b3a3d7b 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.h +++ b/drivers/gpu/drm/bridge/analogix/anx7625.h @@ -350,6 +350,7 @@ struct s_edid_data { struct anx7625_platform_data { struct gpio_desc *gpio_p_on; struct gpio_desc *gpio_reset; + struct regulator_bulk_data supplies[3]; struct drm_bridge *panel_bridge; int intp_irq; u32 low_power_mode; -- 2.30.0.617.g56c4b15f3c-goog