From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A752EC433E0 for ; Sat, 20 Feb 2021 19:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BB6B64E54 for ; Sat, 20 Feb 2021 19:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbhBTTVN convert rfc822-to-8bit (ORCPT ); Sat, 20 Feb 2021 14:21:13 -0500 Received: from mail-ed1-f43.google.com ([209.85.208.43]:40892 "EHLO mail-ed1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229809AbhBTTVM (ORCPT ); Sat, 20 Feb 2021 14:21:12 -0500 Received: by mail-ed1-f43.google.com with SMTP id q10so16619974edt.7; Sat, 20 Feb 2021 11:20:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CdZdY+wjRNfw1jbOEm4Qee3g4OL6v8y6yVQhOX5mqs8=; b=YjkXptnEJPhSRLRlEtM5bfMvpg8M6lw+g6kfj2Boqi+kTy6kayLmATDf70omndHZPO epaJmsHlCWrqiRzLc2oPWPZgCEPutCdME9YV0LYg0f8otIAcc3aE0HQAuld2l4IuoFwT r29gkbHPNt1JEfVxmOAnGr82igRtOtnyh/iKPfMj7jJq2kRyj7By/fAKVNKfwqAAOYzk fsl/LjSRjuO6KrQAeMb6qkUExgA1y2LL3n9rDe6Fouc1VKjEHFDaG9UrCpuMbS16AR7/ d6MTSq1PD8MmK6RWwXJhEcgZslxDgxjsHBtIA0wKsDecEPYNINT3i8VqRTKKsc6eWd2T GAcw== X-Gm-Message-State: AOAM5328YBX3L6AHGXx0/mZpHOrXIde93xVF7zDwz3MIQYLr34/R+PpG A+m0xIoVtNHRdGyUKTrIqec= X-Google-Smtp-Source: ABdhPJzn45HpnhFKzehd0ns6kqR4zObJWCOALH/4m94AbXvp9HI0fkSvQTVqa9Qw9bbLUFuM0NgNxw== X-Received: by 2002:aa7:cd63:: with SMTP id ca3mr8341404edb.119.1613848831058; Sat, 20 Feb 2021 11:20:31 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id m21sm6152746edq.86.2021.02.20.11.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 11:20:30 -0800 (PST) Date: Sat, 20 Feb 2021 20:20:29 +0100 From: Krzysztof Kozlowski To: Adrien Grassein Cc: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , catalin.marinas@arm.com, will@kernel.org, DTML , linux-arm-kernel@lists.infradead.org, linux-kernel Subject: Re: [PATCH v2 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support Message-ID: <20210220192029.nl3mk3b2tejxzyda@kozik-lap> References: <20210217161052.877877-1-adrien.grassein@gmail.com> <20210217161052.877877-4-adrien.grassein@gmail.com> <20210219131947.fcgoshnowurvwqf3@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 19, 2021 at 03:02:35PM +0100, Adrien Grassein wrote: > Le ven. 19 févr. 2021 à 14:19, Krzysztof Kozlowski a écrit : > > > > On Wed, Feb 17, 2021 at 05:10:47PM +0100, Adrien Grassein wrote: > > > Add the description for espi support. > > > > > > Signed-off-by: Adrien Grassein > > > Reviewed-by: Krzysztof Kozlowski > > > --- > > > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 30 +++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > > index f62a25efc69e..c4bb22bb4e6a 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > > @@ -10,6 +10,14 @@ / { > > > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > > > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > > > > > + clock { > > > + clk16m: clk16m { > > > > No changes here. The review tag was conditional in a way that I assumed > > you will implement this change. > > > Sorry I misunderstood your comment. I renamed the "clocks" node. > By the way, after a review, this nod is useless (not used). The "clocks" node was okay, you can also remove it. I was commenting below the clock itself. The device nodes should have generic names, so "clock" or "clock-16m". Best regards, Krzysztof