From: Lee Jones <lee.jones@linaro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-actions@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v7 0/5] Add initial support for ATC260x PMICs
Date: Mon, 22 Feb 2021 16:24:04 +0000 [thread overview]
Message-ID: <20210222162404.GH376568@dell> (raw)
In-Reply-To: <20210222160821.GA468766@BV030612LT>
On Mon, 22 Feb 2021, Cristian Ciocaltea wrote:
> On Mon, Feb 22, 2021 at 03:30:16PM +0000, Lee Jones wrote:
> > On Mon, 22 Feb 2021, Cristian Ciocaltea wrote:
> >
> > > On Mon, Feb 22, 2021 at 09:02:47AM +0000, Lee Jones wrote:
> > > > On Sun, 21 Feb 2021, Cristian Ciocaltea wrote:
> > > >
> > > > > Hi Lee,
> > > > >
> > > > > I have just noticed your mfd-next tag for 5.12 doesn't include the
> > > > > support for the ATC260x PMICs.
> > > > >
> > > > > I assumed the patchset is ready for merging.. Did I miss something?
> > > >
> > > > The MFD driver needs another review.
> > > >
> > > > For some reason, this didn't register on my TODO list.
> > >
> > > You have already tagged v6 with 'Acked-for-MFD-by: Lee Jones
> > > <lee.jones@linaro.org>':
> > > https://lore.kernel.org/lkml/20210125142558.GA4903@dell/
> > >
> > > I have submitted v7 to drop the patches that had been already picked up,
> > > as previously agreed, but otherwise there are no other changes.
> > >
> > > That is why I didn't expect another round of review..
> >
> > I see what's happened. You forgot to:
> >
> > "apply this as-is to your sign-off block"
> >
> > ... as requested, which made me think it needs a subsequent review.
>
> Sorry, I somehow missed that. Should I resend the patch series?
No, no need. It's on my radar now. I'll see to it when v5.12 is out.
> If yes, I assume I should also increment the revision number, even
> though there are no other changes except the addition of the
> indicated tag.
When resending, you only have to s/PATCH/RESEND/.
> > > > In general, if you don't receive a review within ~2 weeks of posting
> > > > (and the merge window is not open), you should consider it lost and
> > > > submit a [RESEND].
> >
> > Due to the fragility of email reviews, this is still very important.
>
> Right, thanks for the hint!
NP.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-02-22 16:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:55 [PATCH v7 0/5] Add initial support for ATC260x PMICs Cristian Ciocaltea
2021-01-26 9:55 ` [PATCH v7 1/5] dt-bindings: input: Add reset-time-sec common property Cristian Ciocaltea
2021-01-26 9:55 ` [PATCH v7 2/5] dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding Cristian Ciocaltea
2021-01-26 9:55 ` [PATCH v7 3/5] mfd: Add MFD driver for ATC260x PMICs Cristian Ciocaltea
2021-01-26 9:56 ` [PATCH v7 4/5] input: atc260x: Add onkey " Cristian Ciocaltea
2021-01-26 9:56 ` [PATCH v7 5/5] MAINTAINERS: Add entry for ATC260x PMIC Cristian Ciocaltea
2021-02-21 16:36 ` [PATCH v7 0/5] Add initial support for ATC260x PMICs Cristian Ciocaltea
2021-02-22 9:02 ` Lee Jones
2021-02-22 15:16 ` Cristian Ciocaltea
2021-02-22 15:30 ` Lee Jones
2021-02-22 16:08 ` Cristian Ciocaltea
2021-02-22 16:24 ` Lee Jones [this message]
2021-03-09 13:53 ` [GIT PULL] Immutable branch between MFD and Input due for the v5.13 merge window Lee Jones
2021-03-09 20:04 ` Lee Jones
2021-03-10 11:12 ` Lee Jones
2021-03-25 19:54 ` Dmitry Torokhov
2021-03-26 8:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222162404.GH376568@dell \
--to=lee.jones@linaro.org \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=cristian.ciocaltea@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).