From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board
Date: Mon, 22 Feb 2021 19:44:17 +0100 [thread overview]
Message-ID: <20210222184417.4nkmdjkgub73b2xd@kozik-lap> (raw)
In-Reply-To: <20210222140756.713-3-heiko.thiery@gmail.com>
On Mon, Feb 22, 2021 at 03:07:56PM +0100, Heiko Thiery wrote:
> The Kontron pitx-imx8m board is based on an i.MX8MQ soc.
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
> - bring root nodes in alphabetical order
> - remove pinctrl_gpio_keys for pciewake
> - remove pinctrl_sai2 and pinctrl_spdfif1 since it is not used yet
>
> Thanks to Michael Walle:
> - add pinctrl for regulator-v-3v3-sd
> - add name for regulator swbst
> - add comment about currently unused audio codec
> - put usb_phy entry in correct alphabetical order
>
> Thanks to Krzysztof Kozlowski:
> - use generic names for pcie-refclk, tpm, fan-controller, sensor
> - remove empty line
> - fix group name to match schema (ecspi2cs -> ecspi2csgrp)
>
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../freescale/imx8mq-kontron-pitx-imx8m.dts | 641 ++++++++++++++++++
> 2 files changed, 642 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
>
Looks fine to me, also with the changes pointed out by Micahel in other
email in this thread:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-02-22 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 14:07 [PATCH v2 0/2] add Kontron pITX-imx8m board Heiko Thiery
2021-02-22 14:07 ` [PATCH v2 1/2] dt-bindings: arm: fsl: " Heiko Thiery
2021-02-22 18:42 ` Krzysztof Kozlowski
2021-02-22 14:07 ` [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board Heiko Thiery
2021-02-22 15:15 ` Michael Walle
2021-02-22 16:57 ` Heiko Thiery
2021-02-22 18:44 ` Krzysztof Kozlowski [this message]
2021-03-02 14:43 ` Fabio Estevam
2021-03-03 12:54 ` Heiko Thiery
2021-03-03 13:00 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222184417.4nkmdjkgub73b2xd@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).