From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2850CC433DB for ; Tue, 23 Feb 2021 16:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E72CF64E3F for ; Tue, 23 Feb 2021 16:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233445AbhBWQKP (ORCPT ); Tue, 23 Feb 2021 11:10:15 -0500 Received: from netrider.rowland.org ([192.131.102.5]:54499 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S233145AbhBWQKO (ORCPT ); Tue, 23 Feb 2021 11:10:14 -0500 Received: (qmail 1264834 invoked by uid 1000); 23 Feb 2021 11:09:32 -0500 Date: Tue, 23 Feb 2021 11:09:32 -0500 From: Alan Stern To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: Florian Fainelli , Jonas Gorski , Greg Kroah-Hartman , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: usb: generic-ehci: document ignore-oc flag Message-ID: <20210223160932.GD1261797@rowland.harvard.edu> References: <20210223155005.21712-1-noltari@gmail.com> <20210223155005.21712-2-noltari@gmail.com> <20210223155443.GB1261797@rowland.harvard.edu> <54E1894F-C8D8-4E2F-92DF-DC891153BAAB@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54E1894F-C8D8-4E2F-92DF-DC891153BAAB@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Feb 23, 2021 at 05:04:57PM +0100, Álvaro Fernández Rojas wrote: > Hi Alan, > > > El 23 feb 2021, a las 16:54, Alan Stern escribió: > > > > On Tue, Feb 23, 2021 at 04:50:04PM +0100, Álvaro Fernández Rojas wrote: > >> Over-current reporting isn't supported on some platforms such as bcm63xx. > >> These devices will incorrectly report over-current if this flag isn't properly > >> activated. > >> > >> Signed-off-by: Álvaro Fernández Rojas > >> --- > >> Documentation/devicetree/bindings/usb/generic-ehci.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > >> index cf83f2d9afac..294bbf02399e 100644 > >> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > >> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > >> @@ -117,6 +117,11 @@ properties: > >> Set this flag if EHCI has a Transaction Translator built into > >> the root hub. > >> > >> + ignore-oc: > >> + $ref: /schemas/types.yaml#/definitions/flag > >> + description: > >> + Set this flag for HCDs without over-current reporting support. > > > > This is not a good description of a device property. DT entries are > > supposed to described the hardware, not talk about how to use it. > > Any suggestions on a proper description? > > > > > When you say that the bcm63xx doesn't support over-current reporting, > > what exactly do you mean? Do you mean that sometimes the hardware turns > > on the over-current bit when an over-current isn't actually present? Or > > do you mean something else? > > Yes, the hardware turns on the over-current bit with no over-current present. Okay, in that case the property should be named something like "spurious_oc", and the description should say something like: Set this flag to indicate that the hardware sometimes turns on the OC bit when an over-current isn't actually present. Alan Stern