devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Pascal Roeleven <dev@pascalroeleven.nl>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Olof Johansson" <olof@lixom.net>,
	soc@kernel.org, "Clément Péron" <peron.clem@gmail.com>,
	"Icenowy Zheng" <icenowy@aosc.io>,
	"Corentin Labbe" <clabbe@baylibre.com>,
	"Martin Cerveny" <m.cerveny@computer.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet
Date: Wed, 24 Feb 2021 11:10:18 +0100	[thread overview]
Message-ID: <20210224101018.ateuj367oqvphyzd@gilmour> (raw)
In-Reply-To: <20210222100826.12478-3-dev@pascalroeleven.nl>

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi,

We're almost there, except for ...

On Mon, Feb 22, 2021 at 11:08:26AM +0100, Pascal Roeleven wrote:
> +&lradc {
> +	vref-supply = <&reg_ldo2>;
> +	status = "okay";
> +
> +	button-761 {
> +		label = "Volume Down";
> +		linux,code = <KEY_VOLUMEDOWN>;
> +		channel = <0>;
> +		voltage = <761904>;
> +	};
> +
> +	button-571 {
> +		label = "Volume Up";
> +		linux,code = <KEY_VOLUMEUP>;
> +		channel = <0>;
> +		voltage = <571428>;
> +	};
> +};

Those nodes should be ordered alphabetically

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2021-02-24 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 10:08 [PATCH v4 0/2] Add support for Topwise A721 tablet Pascal Roeleven
2021-02-22 10:08 ` [PATCH v4 1/2] dt-bindings: arm: Add Topwise A721 Pascal Roeleven
2021-02-22 10:08 ` [PATCH v4 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet Pascal Roeleven
2021-02-24 10:10   ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224101018.ateuj367oqvphyzd@gilmour \
    --to=maxime@cerno.tech \
    --cc=arnd@arndb.de \
    --cc=clabbe@baylibre.com \
    --cc=dev@pascalroeleven.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=m.cerveny@computer.org \
    --cc=olof@lixom.net \
    --cc=peron.clem@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).