From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BBEC433DB for ; Wed, 24 Feb 2021 10:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4F4364EC8 for ; Wed, 24 Feb 2021 10:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234833AbhBXKLg (ORCPT ); Wed, 24 Feb 2021 05:11:36 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:42785 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234826AbhBXKL3 (ORCPT ); Wed, 24 Feb 2021 05:11:29 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 20291580667; Wed, 24 Feb 2021 05:10:23 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 24 Feb 2021 05:10:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=kfzvIjz40bAcKM0RWeUMXud03b2 +MIfE0nrkqnTKGcA=; b=opk4I4Dx/6W+HWKqylTyGHvLGV33WVn/Q3KnHMexGg0 n7DPGt/huewokKLo020DXLHHolgEE08+fv1ZlmS0ErafrN2vFWZr0nGWtAG60gX5 pg59gbMOWwul3eDvdAeALUUd7AreLbfnzeBpirgFkqa6w/dq/vJjrOkBbdg2Qtd3 q1cu7gWTTwzxBVVQHVQn6fD+f0Itaq9/JoJME69ENGXjHNuyKkUkTOosGz1RUbG5 x2Zbkb/keCXjkVFdY+3beNKjGjxJzF2HoO5JOMEO9v1yTAyRYL7W3FebFQxNr3gK kwMYTaZJaa7j1JoRFmYNDKgdMhvJNPMiITm91FYf4gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=kfzvIj z40bAcKM0RWeUMXud03b2+MIfE0nrkqnTKGcA=; b=iJRk8puxfdjOpRWsFeyOJI au5YXH53LN2CKWPN6gQ/7C0UFg0k7XrQTmWr0+OT4PB2mVuYMYNnGKRCoWjeb0m1 FxDLr5HTJCFOzxJMy78KbfAozat5xi1+86Mf1wpUPrVXoASUKrqb9Q3uTyxavZG2 L2ImtoncV+p9Wnf3D9YP0VnsmxjqniRel5amt/KckAwNT0zP59liLRbIxJ2U+R6V AN8U/Ul6BSGO4PualecmZKz+/66Wa3xTQULpUDJ+BvNiOm+PX26B/JmTE9+IQ8pw VCD+q9QXyPy4oPdy31h3bVYXlzkdSjfupmTCAtIwZqR1dY875bx8zN/3/O9OKJeQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeejgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E1FE91080064; Wed, 24 Feb 2021 05:10:19 -0500 (EST) Date: Wed, 24 Feb 2021 11:10:18 +0100 From: Maxime Ripard To: Pascal Roeleven List-Id: Cc: Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Arnd Bergmann , Olof Johansson , soc@kernel.org, =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Icenowy Zheng , Corentin Labbe , Martin Cerveny , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet Message-ID: <20210224101018.ateuj367oqvphyzd@gilmour> References: <20210222100826.12478-1-dev@pascalroeleven.nl> <20210222100826.12478-3-dev@pascalroeleven.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ctatgkubvtbbo6kr" Content-Disposition: inline In-Reply-To: <20210222100826.12478-3-dev@pascalroeleven.nl> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --ctatgkubvtbbo6kr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, We're almost there, except for ... On Mon, Feb 22, 2021 at 11:08:26AM +0100, Pascal Roeleven wrote: > +&lradc { > + vref-supply = <®_ldo2>; > + status = "okay"; > + > + button-761 { > + label = "Volume Down"; > + linux,code = ; > + channel = <0>; > + voltage = <761904>; > + }; > + > + button-571 { > + label = "Volume Up"; > + linux,code = ; > + channel = <0>; > + voltage = <571428>; > + }; > +}; Those nodes should be ordered alphabetically Maxime --ctatgkubvtbbo6kr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYDYmCgAKCRDj7w1vZxhR xXiEAP9TJK18t/Ug+nJChn8xkzq27KvAp4Gagg85nHJfZJRgjwEAwiJM0U80LsFT 1tQoFr85mEnIgd13nceFSuzlLON74QE= =1gnL -----END PGP SIGNATURE----- --ctatgkubvtbbo6kr--