[PATCH 0/2] AM64: Add USB support

[PATCH 0/2] AM64: Add USB support

[Aswath Govindraju]

The following series of patches, add USB support for AM64.

This series of patches depends on,
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039

Aswath Govindraju (2):
  arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
  arm64: dts: ti: k3-am642-evm: Add USB support

 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
 2 files changed, 48 insertions(+)

-- 
2.17.1

[PATCH 1/2] arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem

[Aswath Govindraju]

Add DT node for the single USB subsystem in main dtsi file.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 5f85950daef7..a36ebddf3a4c 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -402,4 +402,34 @@
 		ti,otap-del-sel-ddr50 = <0x9>;
 		ti,clkbuf-sel = <0x7>;
 	};
+
+	usbss0: cdns-usb@f900000{
+		compatible = "ti,am64-usb", "ti,j721e-usb";
+		reg = <0x00 0xf900000 0x00 0x100>;
+		power-domains = <&k3_pds 161 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 161 9>, <&k3_clks 161 1>;
+		clock-names = "ref", "lpm";
+		assigned-clocks = <&k3_clks 161 9>; /* USB2_REFCLK */
+		assigned-clock-parents = <&k3_clks 161 10>; /* HF0SC0 */
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+		usb0: usb@f400000{
+			compatible = "cdns,usb3";
+			reg = <0x00 0xf400000 0x00 0x10000>,
+			      <0x00 0xf410000 0x00 0x10000>,
+			      <0x00 0xf420000 0x00 0x10000>;
+			reg-names = "otg",
+				    "xhci",
+				    "dev";
+			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */
+				     <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>, /* irq.6 */
+				     <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>; /* otgirq */
+			interrupt-names = "host",
+					  "peripheral",
+					  "otg";
+			maximum-speed = "super-speed";
+			dr_mode = "otg";
+		};
+	};
 };
-- 
2.17.1

[PATCH 2/2] arm64: dts: ti: k3-am642-evm: Add USB support

[Aswath Govindraju]

AM64 EVM board has a micro USB 2.0 AB connector and the USB0_VBUS is
connected with a resistor divider in between. USB0_DRVVBUS pin is muxed
between USB0_DRVVBUS and GPIO1_79 signals.

Add the corresponding properties and set the pinmux mode for USB subsystem
in the evm dts file.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 1f1787750fef..bfd849a29655 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -133,6 +133,12 @@
 			AM64X_IOPAD(0x026c, PIN_INPUT_PULLUP, 0) /* (B19) I2C1_SDA */
 		>;
 	};
+
+	main_usb0_pins_default: main-usb0-pins-default {
+		pinctrl-single,pins = <
+			AM64X_IOPAD(0x02a8, PIN_OUTPUT, 0) /* (E19) USB0_DRVVBUS */
+		>;
+	};
 };
 
 &main_uart0 {
@@ -227,6 +233,18 @@
 	status = "disabled";
 };
 
+&usbss0 {
+	ti,vbus-divider;
+	ti,usb2-only;
+};
+
+&usb0 {
+	dr_mode = "otg";
+	maximum-speed = "high-speed";
+	pinctrl-names = "default";
+	pinctrl-0 = <&main_usb0_pins_default>;
+};
+
 &sdhci0 {
 	/* emmc */
 	bus-width = <8>;
-- 
2.17.1

Re: [PATCH 0/2] AM64: Add USB support

[Nishanth Menon]

On 11:21-20210301, Aswath Govindraju wrote:
> The following series of patches, add USB support for AM64.
> 
> This series of patches depends on,
> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039
> 
> Aswath Govindraju (2):
>   arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
>   arm64: dts: ti: k3-am642-evm: Add USB support
> 
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
>  2 files changed, 48 insertions(+)

Please update the series to include SK as well.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH 0/2] AM64: Add USB support

[Aswath Govindraju]

Hi Nishanth,

On 01/03/21 8:52 pm, Nishanth Menon wrote:
> On 11:21-20210301, Aswath Govindraju wrote:
>> The following series of patches, add USB support for AM64.
>>
>> This series of patches depends on,
>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039
>>
>> Aswath Govindraju (2):
>>   arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
>>   arm64: dts: ti: k3-am642-evm: Add USB support
>>
>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
>>  2 files changed, 48 insertions(+)
> 
> Please update the series to include SK as well.
> 

I was planning on posting patches that add support for USB in SK later
because of phy dependencies.

Thanks,
Aswath

Re: [PATCH 0/2] AM64: Add USB support

[Kishon Vijay Abraham I]

+Vinod

Hi Aswath,

On 10/03/21 12:27 pm, Aswath Govindraju wrote:
> Hi Nishanth,
> 
> On 01/03/21 8:52 pm, Nishanth Menon wrote:
>> On 11:21-20210301, Aswath Govindraju wrote:
>>> The following series of patches, add USB support for AM64.
>>>
>>> This series of patches depends on,
>>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039
>>>
>>> Aswath Govindraju (2):
>>>   arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
>>>   arm64: dts: ti: k3-am642-evm: Add USB support
>>>
>>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
>>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
>>>  2 files changed, 48 insertions(+)
>>
>> Please update the series to include SK as well.
>>
> 
> I was planning on posting patches that add support for USB in SK later
> because of phy dependencies.

The dependency is only on [1] right? I've got all the required ACKs so
it should be okay to include it in this series. (That patch will be
required only when PCIe DT is merged for me.)

Nishant, would you be okay to merge [1] along with other patches from
Aswath? There is no dependency as such on my other PHY patches, so don't
think there is a need for a stable tag here.

Thanks
Kishon

[1] ->
https://lore.kernel.org/linux-devicetree/20210222112314.10772-4-kishon@ti.com/
> 
> Thanks,
> Aswath
> 

Re: [PATCH 0/2] AM64: Add USB support

[Aswath Govindraju]

Hi Kishon,

On 10/03/21 12:33 pm, Kishon Vijay Abraham I wrote:
> +Vinod
> 
> Hi Aswath,
> 
> On 10/03/21 12:27 pm, Aswath Govindraju wrote:
>> Hi Nishanth,
>>
>> On 01/03/21 8:52 pm, Nishanth Menon wrote:
>>> On 11:21-20210301, Aswath Govindraju wrote:
>>>> The following series of patches, add USB support for AM64.
>>>>
>>>> This series of patches depends on,
>>>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039
>>>>
>>>> Aswath Govindraju (2):
>>>>   arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
>>>>   arm64: dts: ti: k3-am642-evm: Add USB support
>>>>
>>>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
>>>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
>>>>  2 files changed, 48 insertions(+)
>>>
>>> Please update the series to include SK as well.
>>>
>>
>> I was planning on posting patches that add support for USB in SK later
>> because of phy dependencies.
> 
> The dependency is only on [1] right? I've got all the required ACKs so
> it should be okay to include it in this series. (That patch will be
> required only when PCIe DT is merged for me.)
> 
> Nishant, would you be okay to merge [1] along with other patches from
> Aswath? There is no dependency as such on my other PHY patches, so don't
> think there is a need for a stable tag here.
> 
> 
> [1] ->
> https://lore.kernel.org/linux-devicetree/20210222112314.10772-4-kishon@ti.com/
>>

There is also a dependency on,

https://lore.kernel.org/linux-devicetree/20210222112314.10772-2-kishon@ti.com/

Thanks,
Aswath