From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEF1C41518 for ; Tue, 2 Mar 2021 20:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9445F64F21 for ; Tue, 2 Mar 2021 20:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1837019AbhCBU3n (ORCPT ); Tue, 2 Mar 2021 15:29:43 -0500 Received: from rcdn-iport-3.cisco.com ([173.37.86.74]:27943 "EHLO rcdn-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1579959AbhCBRVU (ORCPT ); Tue, 2 Mar 2021 12:21:20 -0500 X-Greylist: delayed 458 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Mar 2021 12:21:19 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1625; q=dns/txt; s=iport; t=1614705679; x=1615915279; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ImvxV88MVdFuksRY57yHoR9ifNWa1nbpC7IuceuHtdI=; b=DHJAmi6pIanMDzLMZhoQrTts24E3LqKzVJ5nni6NvEjg3FmDN2j6Cumj YNKnQsGi3qQYsPTsRONPszom2VzU34ebhAKmJS4FY5TSaqBi75QZ7h90z j5/OwAcQSq63ofvt3UYFXTCKwun+OV4SrCd1soTUhyUgt3Ws+86YfOH0R U=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BKAwC9cD5g/5RdJa1iHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAgU+CK3ZWATkxA5Yaj3oWilOBaAsBAQENAQEqCgQBAYRNAoF?= =?us-ascii?q?6AiU4EwIDAQELAQEFAQEBAgEGBHGFYQ2GRQEFOjQLEAsYLjwKEQYTgnGDBw+?= =?us-ascii?q?sa3SBNIRAAYRigT4GIoEWjUMmHIFJQoQrPoQJARIBg2uCKwSEAYIxQ5MVAYo?= =?us-ascii?q?tm3uDBoEfiCCSUjEQgyeQSo9VLZYxiTSWYAIEBgUCFoFrI2dwMxoIGxU7gmk?= =?us-ascii?q?TPRkNjisWiGGFZiADLwI2AgYKAQEDCYwTAQE?= X-IronPort-AV: E=Sophos;i="5.81,217,1610409600"; d="scan'208";a="842559803" Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 02 Mar 2021 17:12:53 +0000 Received: from zorba ([10.24.9.198]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id 122HCpOe014626 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 2 Mar 2021 17:12:52 GMT Date: Tue, 2 Mar 2021 09:12:51 -0800 From: Daniel Walker To: Rob Herring Cc: Will Deacon , Chris Packham , "linux-kernel@vger.kernel.org" , Max Uvarov , Ard Biesheuvel , Marc Zyngier , Doug Anderson , Tyler Hicks , Frank Rowand , Arnd Bergmann , Palmer Dabbelt , Greg Kroah-Hartman , Catalin Marinas , Android Kernel Team , linux-arm-kernel , devicetree@vger.kernel.org, linuxppc-dev , Michael Ellerman Subject: Re: [PATCH 0/2] Fix CMDLINE_EXTEND handling for FDT "bootargs" Message-ID: <20210302171251.GB109100@zorba> References: <20210225125921.13147-1-will@kernel.org> <20210301144153.GA16716@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Outbound-SMTP-Client: 10.24.9.198, [10.24.9.198] X-Outbound-Node: rcdn-core-12.cisco.com Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 01, 2021 at 11:26:14AM -0600, Rob Herring wrote: > +PPC folks and Daniel W > > On Mon, Mar 1, 2021 at 8:42 AM Will Deacon wrote: > > > > On Mon, Mar 01, 2021 at 08:19:32AM -0600, Rob Herring wrote: > > > On Thu, Feb 25, 2021 at 6:59 AM Will Deacon wrote: > > > > We recently [1] enabled support for CMDLINE_EXTEND on arm64, however > > > > when I started looking at replacing Android's out-of-tree implementation [2] > > > > > > Did anyone go read the common, reworked version of all this I > > > referenced that supports prepend and append. Here it is again[1]. > > > Maybe I should have been more assertive there and said 'extend' is > > > ambiguous. > > > > I tried reading that, but (a) most of the series is not in the mailing list > > archives and (b) the patch that _is_ doesn't touch CMDLINE_EXTEND at all. > > Right now the code in mainline does the opposite of what it's documented to > > do. > > Actually, there is a newer version I found: > > https://lore.kernel.org/linuxppc-dev/1551469472-53043-1-git-send-email-danielwa@cisco.com/ > https://lore.kernel.org/linuxppc-dev/1551469472-53043-2-git-send-email-danielwa@cisco.com/ > https://lore.kernel.org/linuxppc-dev/1551469472-53043-3-git-send-email-danielwa@cisco.com/ > > (Once again, there's some weird threading going on) > I'm happy to work with anyone to resubmit the changes. We currently use the changes in Cisco, and we have used them for many years. I was planning to update and resubmit since someone has recently inquired about why it wasn't upstream. Daniel