From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93735C41518 for ; Wed, 3 Mar 2021 19:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A75A64EF8 for ; Wed, 3 Mar 2021 19:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1579657AbhCCSbs (ORCPT ); Wed, 3 Mar 2021 13:31:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:46200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383252AbhCCNpU (ORCPT ); Wed, 3 Mar 2021 08:45:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B312C64EC3; Wed, 3 Mar 2021 13:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614779070; bh=70K+Awdb6JRP3kxW9t++h7jkIc73yW8tJioYK4hP5OA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NnT+7vSXIVNsaJWg2HE5SzxwK7QTgin2q3DKtUihgGnnHf3h38iAruPIoXBN8x0NR /wrmabn3krZKwh7LEtkm4LpeHJehVy/ZkvaJ3g/CNj2hma58G8H92QU063yFudmnlV 014y0+wKjf3rCsJQ8npXCvaE6T8+1QH/xzewliK/eP4F8tRYdxbByidjyOcrK6/aAc 53vZ0ellUmT4oVy7WpVbO7OjbcFCq7oPnX10oV/qkAJoqdU4uCdRX2dBQiMwWyN/jo ydY0ORSm0XQwtGba+rJq5pQTFMjvenJurWECWjZYd4iPgIAMUyuDW4puHjzGy62THC UdcPzdNk5smGQ== Date: Wed, 3 Mar 2021 21:44:23 +0800 From: Shawn Guo To: Alistair Francis Cc: arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alistair23@gmail.com Subject: Re: [PATCH v3 1/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2 Message-ID: <20210303134422.GJ15865@dragon> References: <20210204030316.489-1-alistair@alistair23.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204030316.489-1-alistair@alistair23.me> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Feb 03, 2021 at 07:03:14PM -0800, Alistair Francis wrote: > The reMarkable2 (https://remarkable.com) is an e-ink tablet based on > the imx7d SoC. > > This commit is based on the DTS provide by reMarkable but ported to the > latest kernel (instead of 4.14). I have removed references to > non-upstream devices and have changed the UART so that the console can > be accessed without having to open up the device via the OTG pogo pins. Just out of curiosity, this is a DIY cable or something generally available from vendor? > > Currently the kernel boots, but there is no support for the dispaly, > WiFi or the power controller chips. There are still some WiFi related devices. Can we drop all those untested stuff? > > Signed-off-by: Alistair Francis > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx7d-remarkable2.dts | 253 ++++++++++++++++++++++++ > 2 files changed, 254 insertions(+) > create mode 100644 arch/arm/boot/dts/imx7d-remarkable2.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 3d1ea0b25168..9608c363b25f 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -658,6 +658,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \ > imx7d-pico-hobbit.dtb \ > imx7d-pico-nymph.dtb \ > imx7d-pico-pi.dtb \ > + imx7d-remarkable2.dtb \ > imx7d-sbc-imx7.dtb \ > imx7d-sdb.dtb \ > imx7d-sdb-reva.dtb \ > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > new file mode 100644 > index 000000000000..0aae13f5eed6 > --- /dev/null > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -0,0 +1,253 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2015 Freescale Semiconductor, Inc. > + * Copyright (C) 2019 reMarkable AS - http://www.remarkable.com/ > + * > + */ > + > +/dts-v1/; > + > +#include "imx7d.dtsi" > + > +/ { > + model = "reMarkable 2.0"; > + compatible = "fsl,imx7d-remarkable2", "fsl,imx7d"; The new compatible needs to be documented. Also the compatible doesn't look right, as this is a device from reMarkable rather than FSL. Shawn > + > + chosen { > + stdout-path = &uart6; > + }; > + > + memory { > + reg = <0x80000000 0x40000000>; > + }; > + > + reg_brcm: regulator-brcm { > + compatible = "regulator-fixed"; > + regulator-name = "brcm_reg"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_brcm_reg>; > + gpio = <&gpio6 13 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + startup-delay-us = <150>; > + }; > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wifi>; > + reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > + clocks = <&clks IMX7D_CLKO2_ROOT_DIV>; > + clock-names = "ext_clock"; > + }; > +}; > + > +&clks { > + assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>, > + <&clks IMX7D_CLKO2_ROOT_DIV>; > + assigned-clock-parents = <&clks IMX7D_CKIL>; > + assigned-clock-rates = <0>, <32768>; > +}; > + > +&crypto { > + status = "disabled"; > +}; > + > +&dma_apbh { > + status = "disabled"; > +}; > + > +&sdma { > + status = "okay"; > +}; > + > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + assigned-clocks = <&clks IMX7D_UART1_ROOT_SRC>; > + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>; > + status = "okay"; > +}; > + > +&uart6 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart6>; > + assigned-clocks = <&clks IMX7D_UART6_ROOT_SRC>; > + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>; > + status = "okay"; > +}; > + > +&usbotg2 { > + srp-disable; > + hnp-disable; > + status = "okay"; > +}; > + > +&usdhc2 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default", "state_100mhz", "sleep"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc2>; > + mmc-pwrseq = <&wifi_pwrseq>; > + vmmc-supply = <®_brcm>; > + bus-width = <4>; > + non-removable; > + keep-power-in-suspend; > + cap-power-off-card; > + status = "okay"; > + > + brcmf: bcrmf@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > +&usdhc3 { > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > + pinctrl-3 = <&pinctrl_usdhc3>; > + assigned-clocks = <&clks IMX7D_USDHC3_ROOT_CLK>; > + assigned-clock-rates = <400000000>; > + bus-width = <8>; > + non-removable; > + status = "okay"; > +}; > + > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > +&iomuxc_lpsr { > + pinctrl_digitizer_reg: digitizerreggrp { > + fsl,pins = < > + /* DIGITIZER_PWR_EN */ > + MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x14 > + >; > + }; > +}; > + > +&iomuxc { > + pinctrl_brcm_reg: brcmreggrp { > + fsl,pins = < > + /* WIFI_PWR_EN */ > + MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14 > + >; > + }; > + > + pinctrl_uart1: uart1grp { > + fsl,pins = < > + MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > + MX7D_PAD_UART1_RX_DATA__UART1_DCE_RX 0x79 > + >; > + }; > + > + pinctrl_uart6: uart6grp { > + fsl,pins = < > + MX7D_PAD_EPDC_DATA09__UART6_DCE_TX 0x79 > + MX7D_PAD_EPDC_DATA08__UART6_DCE_RX 0x79 > + >; > + }; > + > + pinctrl_usdhc2: usdhc2grp { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x59 > + MX7D_PAD_SD2_CLK__SD2_CLK 0x19 > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59 > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59 > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59 > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59 > + >; > + }; > + > + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x5a > + MX7D_PAD_SD2_CLK__SD2_CLK 0x1a > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5a > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x5a > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x5a > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x5a > + >; > + }; > + > + pinctrl_usdhc2_200mhz: usdhc2grp_200mhz { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x5b > + MX7D_PAD_SD2_CLK__SD2_CLK 0x1b > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5b > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x5b > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x5b > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x5b > + >; > + }; > + > + pinctrl_usdhc3: usdhc3grp { > + fsl,pins = < > + MX7D_PAD_SD3_CMD__SD3_CMD 0x59 > + MX7D_PAD_SD3_CLK__SD3_CLK 0x19 > + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x59 > + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x59 > + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x59 > + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x59 > + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x59 > + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x59 > + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x59 > + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x59 > + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x19 > + >; > + }; > + > + pinctrl_usdhc3_100mhz: usdhc3grp_100mhz { > + fsl,pins = < > + MX7D_PAD_SD3_CMD__SD3_CMD 0x5a > + MX7D_PAD_SD3_CLK__SD3_CLK 0x1a > + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5a > + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x5a > + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x5a > + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x5a > + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x5a > + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x5a > + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x5a > + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x5a > + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x1a > + >; > + }; > + > + pinctrl_usdhc3_200mhz: usdhc3grp_200mhz { > + fsl,pins = < > + MX7D_PAD_SD3_CMD__SD3_CMD 0x5b > + MX7D_PAD_SD3_CLK__SD3_CLK 0x1b > + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5b > + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x5b > + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x5b > + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x5b > + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x5b > + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x5b > + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x5b > + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x5b > + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x1b > + >; > + }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX7D_PAD_ENET1_COL__WDOG1_WDOG_ANY 0x74 > + >; > + }; > + > + pinctrl_wifi: wifigrp { > + fsl,pins = < > + /* WiFi Reg On */ > + MX7D_PAD_SD2_CD_B__GPIO5_IO9 0x00000014 > + /* WiFi Sleep 32k */ > + MX7D_PAD_SD1_WP__CCM_CLKO2 0x00000014 > + >; > + }; > +}; > -- > 2.30.0 >