[PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards

[PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards

[Geert Uytterhoeven]

	Hi all,

This patch series adds the device nodes for all I2C EEPROMs in the
Falcon board stack.  As some EEPROMs are located on sub-boards,
it also introduces individual .dtsi files for these sub-boards.
Note that (for now) these sub-boards don't have compatible values or
model strings, as I think this needs more discussion.

This has been tested on the Falcon boards in Magnus' and Kieran's farms.
The EEPROM on the CPU board in Magnus' farm contains some data.
All other EEPROMs are present, but in pristine state (all ones).

Changes compared to v1:
  - Move EEPROMs in sub-boards to separate .dtsi files and patches.

To be queued in renesas-devel for v5.13.

Thanks for your comments!

Geert Uytterhoeven (3):
  arm64: dts: renesas: falcon: Add I2C EEPROM nodes
  arm64: dts: renesas: falcon: Add CSI/DSI sub-board
  arm64: dts: renesas: falcon: Add Ethernet sub-board

 .../boot/dts/renesas/r8a779a0-falcon-cpu.dtsi     |  7 +++++++
 .../boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi | 15 +++++++++++++++
 .../dts/renesas/r8a779a0-falcon-ethernet.dtsi     | 15 +++++++++++++++
 arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts   | 11 +++++++++++
 4 files changed, 48 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779a0-falcon-ethernet.dtsi

-- 
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH v2 1/3] arm64: dts: renesas: falcon: Add I2C EEPROM nodes

[Geert Uytterhoeven]

Add device nodes for the I2C EEPROMs on the Falcon CPU and BreakOut
boards.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop EEPROMs not located on the CPU or BreakOut board.
---
 arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi | 7 +++++++
 arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts      | 9 +++++++++
 2 files changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
index fa284a7260d68251..286a5d5b9b08ff88 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
@@ -82,6 +82,13 @@ &i2c0 {
 
 	status = "okay";
 	clock-frequency = <400000>;
+
+	eeprom@50 {
+		compatible = "rohm,br24g01", "atmel,24c01";
+		label = "cpu-board";
+		reg = <0x50>;
+		pagesize = <8>;
+	};
 };
 
 &i2c1 {
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
index 5617b81dd7dc3e87..2047fc475a524576 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
@@ -22,6 +22,15 @@ chosen {
 	};
 };
 
+&i2c0 {
+	eeprom@51 {
+		compatible = "rohm,br24g01", "atmel,24c01";
+		label = "breakout-board";
+		reg = <0x51>;
+		pagesize = <8>;
+	};
+};
+
 &rwdt {
 	timeout-sec = <60>;
 	status = "okay";
-- 
2.25.1

[PATCH v2 2/3] arm64: dts: renesas: falcon: Add CSI/DSI sub-board

[Geert Uytterhoeven]

Add a DTS file for the Falcon CSI/DSI sub-board (RTP0RC779A0DCS0010S),
and include it from the main r8a779a0-falcon.dts.

For now its contents are limited to the Board ID EEPROM.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New (eeprom node extracted from first patch).
---
 .../boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi | 15 +++++++++++++++
 arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts   |  1 +
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi
new file mode 100644
index 0000000000000000..14d3db5d6c16485d
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the Falcon CSI/DSI sub-board
+ *
+ * Copyright (C) 2021 Glider bv
+ */
+
+&i2c0 {
+	eeprom@52 {
+		compatible = "rohm,br24g01", "atmel,24c01";
+		label = "csi-dsi-sub-board-id";
+		reg = <0x52>;
+		pagesize = <8>;
+	};
+};
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
index 2047fc475a524576..59d21d88788be6e8 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
@@ -7,6 +7,7 @@
 
 /dts-v1/;
 #include "r8a779a0-falcon-cpu.dtsi"
+#include "r8a779a0-falcon-csi-dsi.dtsi"
 
 / {
 	model = "Renesas Falcon CPU and Breakout boards based on r8a779a0";
-- 
2.25.1

[PATCH v2 3/3] arm64: dts: renesas: falcon: Add Ethernet sub-board

[Geert Uytterhoeven]

Add a DTS file for the Falcon Ethernet sub-board (RTP0RC779A0ETS0010S),
and include it from the main r8a779a0-falcon.dts.

For now its contents are limited to the Board ID EEPROM.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New (eeprom node extracted from first patch).
---
 .../dts/renesas/r8a779a0-falcon-ethernet.dtsi     | 15 +++++++++++++++
 arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts   |  1 +
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779a0-falcon-ethernet.dtsi

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-ethernet.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-ethernet.dtsi
new file mode 100644
index 0000000000000000..e11bf9ace7768d54
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-ethernet.dtsi
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the Falcon Ethernet sub-board
+ *
+ * Copyright (C) 2021 Glider bv
+ */
+
+&i2c0 {
+	eeprom@53 {
+		compatible = "rohm,br24g01", "atmel,24c01";
+		label = "ethernet-sub-board-id";
+		reg = <0x53>;
+		pagesize = <8>;
+	};
+};
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
index 59d21d88788be6e8..7bc964c36f331270 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
@@ -8,6 +8,7 @@
 /dts-v1/;
 #include "r8a779a0-falcon-cpu.dtsi"
 #include "r8a779a0-falcon-csi-dsi.dtsi"
+#include "r8a779a0-falcon-ethernet.dtsi"
 
 / {
 	model = "Renesas Falcon CPU and Breakout boards based on r8a779a0";
-- 
2.25.1

Re: [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

On Thu, Mar 04, 2021 at 04:32:54PM +0100, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series adds the device nodes for all I2C EEPROMs in the
> Falcon board stack.  As some EEPROMs are located on sub-boards,
> it also introduces individual .dtsi files for these sub-boards.
> Note that (for now) these sub-boards don't have compatible values or
> model strings, as I think this needs more discussion.
> 
> This has been tested on the Falcon boards in Magnus' and Kieran's farms.
> The EEPROM on the CPU board in Magnus' farm contains some data.
> All other EEPROMs are present, but in pristine state (all ones).
> 
> Changes compared to v1:
>   - Move EEPROMs in sub-boards to separate .dtsi files and patches.
> 

Checked the datasheets and tested, too, so:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

One minor question is: why do the labels in patches 2+3 have the "-id"
suffix and patch 1 does not? Don't we want consistency here?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards

[Geert Uytterhoeven]

Hi Wolfram,

On Fri, Mar 5, 2021 at 3:15 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Thu, Mar 04, 2021 at 04:32:54PM +0100, Geert Uytterhoeven wrote:
> > This patch series adds the device nodes for all I2C EEPROMs in the
> > Falcon board stack.  As some EEPROMs are located on sub-boards,
> > it also introduces individual .dtsi files for these sub-boards.
> > Note that (for now) these sub-boards don't have compatible values or
> > model strings, as I think this needs more discussion.
> >
> > This has been tested on the Falcon boards in Magnus' and Kieran's farms.
> > The EEPROM on the CPU board in Magnus' farm contains some data.
> > All other EEPROMs are present, but in pristine state (all ones).
> >
> > Changes compared to v1:
> >   - Move EEPROMs in sub-boards to separate .dtsi files and patches.
> >
>
> Checked the datasheets and tested, too, so:
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks!

> One minor question is: why do the labels in patches 2+3 have the "-id"
> suffix and patch 1 does not? Don't we want consistency here?

The EEPROMs on the sub-boards are labeled "Board ID" in the
schematics, the EEPROMs on the CPU and BreakOut board aren't.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]


> > One minor question is: why do the labels in patches 2+3 have the "-id"
> > suffix and patch 1 does not? Don't we want consistency here?
> 
> The EEPROMs on the sub-boards are labeled "Board ID" in the
> schematics, the EEPROMs on the CPU and BreakOut board aren't.

OK, super fine with me.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]