From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
linux-arm-msm@vger.kernel.org, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
boris.brezillon@collabora.com
Subject: Re: [PATCH 2/3] dt-bindings: mtd: Add a property to declare secure regions in Qcom NANDc
Date: Fri, 5 Mar 2021 17:36:57 -0600 [thread overview]
Message-ID: <20210305233657.GA839767@robh.at.kernel.org> (raw)
In-Reply-To: <20210222120259.94465-3-manivannan.sadhasivam@linaro.org>
On Mon, Feb 22, 2021 at 05:32:58PM +0530, Manivannan Sadhasivam wrote:
> On a typical end product, a vendor may choose to secure some regions in
> the NAND memory which are supposed to stay intact between FW upgrades.
> The access to those regions will be blocked by a secure element like
> Trustzone. So the normal world software like Linux kernel should not
> touch these regions (including reading).
>
> So let's add a property for declaring such secure regions so that the
> driver can skip touching them.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/mtd/qcom,nandc.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> index 84ad7ff30121..7500e20da9c1 100644
> --- a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> +++ b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> @@ -48,6 +48,13 @@ patternProperties:
> enum:
> - 512
>
> + qcom,secure-regions:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
Don't you need 64-bit regions potentially? Though 4GB should be enough
for anyone.
If more than one addr+size, then you need a matrix.
> + description:
> + Regions in the NAND memory which are protected using a secure element
> + like Trustzone. This property contains the start address and size of
> + the secure regions present (optional).
> +
> allOf:
> - $ref: "nand-controller.yaml#"
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-03-05 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 12:02 [PATCH 0/3] Add support for secure regions in Qcom NANDc driver Manivannan Sadhasivam
2021-02-22 12:02 ` [PATCH 1/3] dt-bindings: mtd: Convert Qcom NANDc binding to YAML Manivannan Sadhasivam
2021-02-22 12:02 ` [PATCH 2/3] dt-bindings: mtd: Add a property to declare secure regions in Qcom NANDc Manivannan Sadhasivam
2021-02-23 16:49 ` Miquel Raynal
2021-02-23 17:45 ` Manivannan Sadhasivam
2021-02-23 17:56 ` Miquel Raynal
2021-03-05 23:36 ` Rob Herring [this message]
2021-03-08 5:31 ` Manivannan Sadhasivam
2021-03-10 2:32 ` Rob Herring
2021-03-10 3:45 ` Manivannan Sadhasivam
2021-02-22 12:02 ` [PATCH 3/3] mtd: rawnand: qcom: Add support for secure regions in NAND memory Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305233657.GA839767@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).