From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896F7C433DB for ; Sat, 6 Mar 2021 20:59:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57CCD64F87 for ; Sat, 6 Mar 2021 20:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbhCFU71 (ORCPT ); Sat, 6 Mar 2021 15:59:27 -0500 Received: from mail-qt1-f182.google.com ([209.85.160.182]:40353 "EHLO mail-qt1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbhCFU7E (ORCPT ); Sat, 6 Mar 2021 15:59:04 -0500 Received: by mail-qt1-f182.google.com with SMTP id h9so4681016qtq.7; Sat, 06 Mar 2021 12:59:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SFEqSSwSe/KzR9VZCsRqchghKKejji8suG50GSay0+M=; b=W4rdmm2fDmygn+S1ssF5Fr40mQQfX8G+0XnjsJB7X53XVaFiZJMOBp1aiJlGYzQGUv HMNuStEyoSOTUUwwvEtxOTlnGMSX6m0/p2mu2+3lXa9w7ThoOUrXQKpWF+jTz9v7Ob8G WIcPEu15c2VMlHyvNJyAcoWUfcILtlvPeUAbcS/UaoCUZ4IRlSK4H3V2lohd2ph9K24j gVXJMeSFhNSnutE0xygu/n1xjpNTJJ12KMK/XNHqNs1PGwkPV0yl+y7CopvMbOMG0ZQC oFJidG8xNAY+VaFH2X49ULnHEhXxIsde0tYDdvzOzHjcqgitj+8g7nxqhM/jLmaT+wMD 3gLw== X-Gm-Message-State: AOAM530wMSIF/MhSJS2UZ+Ang6JVz2qLXkS6aavgwuzAaLCoi7M7f3Mk yIAivcki8NB91QQtQ6gmFg== X-Google-Smtp-Source: ABdhPJzrYbstCQbyHTs+LKACy+Q3EGh7gYXWL5eAQ6ICuGWnppDHWTdn2sYJwbL2bRd21rCJqClYwA== X-Received: by 2002:ac8:7359:: with SMTP id q25mr15066984qtp.202.1615064343319; Sat, 06 Mar 2021 12:59:03 -0800 (PST) Received: from robh.at.kernel.org ([172.58.27.98]) by smtp.gmail.com with ESMTPSA id v187sm4551721qkd.50.2021.03.06.12.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 12:59:02 -0800 (PST) Received: (nullmailer pid 1202783 invoked by uid 1000); Sat, 06 Mar 2021 20:58:55 -0000 Date: Sat, 6 Mar 2021 13:58:55 -0700 From: Rob Herring To: Quan Nguyen Cc: Joel Stanley , Andrew Jeffery , Jean Delvare , Guenter Roeck , Lee Jones , Jonathan Corbet , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers Message-ID: <20210306205855.GA1195877@robh.at.kernel.org> References: <20210225101854.13896-1-quan@os.amperecomputing.com> <20210225101854.13896-2-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225101854.13896-2-quan@os.amperecomputing.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Feb 25, 2021 at 05:18:51PM +0700, Quan Nguyen wrote: > Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware > reference platform with Ampere's Altra Processor family. > > Signed-off-by: Quan Nguyen > --- > .../bindings/hwmon/ampere,ac01-hwmon.yaml | 27 ++++++ > .../bindings/mfd/ampere,ac01-smpro.yaml | 82 +++++++++++++++++++ > 2 files changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml > create mode 100644 Documentation/devicetree/bindings/mfd/ampere,ac01-smpro.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml > new file mode 100644 > index 000000000000..d13862ba646b > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/ampere,ac01-hwmon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hardware monitoring driver for the Ampere Altra SMPro > + > +maintainers: > + - Quan Nguyen > + > +description: | > + This module is part of the Ampere Altra SMPro multi-function device. For more > + details see ../mfd/ampere,ac01-smpro.yaml. > + > +properties: > + compatible: > + enum: > + - ampere,ac01-hwmon > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + > +additionalProperties: false > diff --git a/Documentation/devicetree/bindings/mfd/ampere,ac01-smpro.yaml b/Documentation/devicetree/bindings/mfd/ampere,ac01-smpro.yaml > new file mode 100644 > index 000000000000..06b0239413ae > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ampere,ac01-smpro.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/ampere,ac01-smpro.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ampere Altra SMPro firmware driver > + > +maintainers: > + - Quan Nguyen > + > +description: | > + Ampere Altra SMPro firmware may contain different blocks like hardware > + monitoring, error monitoring and other miscellaneous features. > + > +properties: > + compatible: > + const: ampere,ac01-smpro > + > + reg: > + description: > + I2C device address. > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^hwmon(@[0-9a-f]+)?$": > + $ref: ../hwmon/ampere,ac01-hwmon.yaml > + > + "^misc(@[0-9a-f]+)?$": > + type: object > + description: Ampere Altra SMPro Misc driver > + properties: > + compatible: > + const: "ampere,ac01-misc" > + > + "^errmon(@[0-9a-f]+)?$": > + type: object > + description: Ampere Altra SMPro Error Monitor driver > + properties: > + compatible: > + const: "ampere,ac01-errmon" > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + smpro@4f { > + compatible = "ampere,ac01-smpro"; > + reg = <0x4f>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hwmon { > + compatible = "ampere,ac01-hwmon"; > + }; > + > + misc { > + compatible = "ampere,ac01-misc"; > + }; > + > + errmon { > + compatible = "ampere,ac01-errmon"; > + }; No of these have any properties or resources, why do you need them? DT is not the only way to instantiate drivers... Rob