From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH v3 2/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos4412 Odroid
Date: Sun, 7 Mar 2021 21:30:11 +0100 [thread overview]
Message-ID: <20210307203011.zeylib7afgvc5zhd@kozik-lap> (raw)
In-Reply-To: <d53d0b67-2368-1434-ab00-fb37b1e824a6@samsung.com>
On Mon, Sep 21, 2020 at 11:42:40AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 11.09.2020 16:54, Krzysztof Kozlowski wrote:
> > On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote:
> >> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
> >> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
> >>
> >> However the dtschema expects "clocks" property if "assigned-clocks" are
> >> used. Add reference to input clock, the parent used in
> >> "assigned-clock-parents" to silence the dtschema warnings:
> >>
> >> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
> >>
> > Applied.
>
> This patch breaks operation of clocks on Odroid X2/U3:
>
> # dmesg | grep clk
> [ 0.000000] exynos_clkout_init: failed to register clkout clock
> [ 0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll =
> 800000000
> sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk =
> 1000000000
> [ 2.569484] usb3503 0-0008: unable to request refclk (-517)
> [ 2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2
> (50000000 Hz)
> [ 3.373850] usb3503 0-0008: unable to request refclk (-517)
> [ 3.542777] usb3503 0-0008: unable to request refclk (-517)
> [ 3.544005] usb3503 0-0008: unable to request refclk (-517)
> [ 3.559223] usb3503 0-0008: unable to request refclk (-517)
>
> Please revert or drop if possible.
I re-applied this one (it was once reverted), as clkout was converted to
proper driver. My Odroid U3 boots fine now with this patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-03-07 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 14:21 [PATCH v3 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 Krzysztof Kozlowski
2020-09-06 14:21 ` [PATCH v3 2/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos4412 Odroid Krzysztof Kozlowski
2020-09-11 14:54 ` Krzysztof Kozlowski
2020-09-21 9:42 ` Marek Szyprowski
2020-09-21 10:07 ` Krzysztof Kozlowski
2021-03-07 20:30 ` Krzysztof Kozlowski [this message]
2020-09-06 14:21 ` [PATCH v3 3/3] ARM: dts: exynos: Add clocks sound node in Exynos5422 Odroid XU4 Krzysztof Kozlowski
2020-09-11 14:54 ` Krzysztof Kozlowski
2020-09-11 14:53 ` [PATCH v3 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307203011.zeylib7afgvc5zhd@kozik-lap \
--to=krzysztof.kozlowski@canonical.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).