* [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high
@ 2021-03-07 19:28 Paul Cercueil
2021-03-07 19:28 ` [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS Paul Cercueil
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Paul Cercueil @ 2021-03-07 19:28 UTC (permalink / raw)
To: Thomas Bogendoerfer, Rob Herring
Cc: od, dri-devel, devicetree, linux-kernel, linux-mips,
Paul Cercueil
The NT39016 panel is a fun beast, even though the documentation states
that the CS line is active-low, it will work just fine if the CS line is
configured as active-high, but it won't work if the CS line is forced
low or forced high.
Since it did actually work with the spi-cs-high property, this is not a
bugfix, but we should nonetheless remove that property from the example
to match the documentation.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
.../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
index 6960036975fa..c45c92a3d41f 100644
--- a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
+++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
@@ -47,7 +47,6 @@ examples:
spi-max-frequency = <3125000>;
spi-3wire;
- spi-cs-high;
reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS
2021-03-07 19:28 [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high Paul Cercueil
@ 2021-03-07 19:28 ` Paul Cercueil
2021-03-12 15:00 ` Thomas Bogendoerfer
2021-03-08 23:01 ` [PATCH 1/2] dt-bindings: panel/kingdisplay, kd035g6-54nt: Remove spi-cs-high Rob Herring
2021-03-12 15:00 ` [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: " Thomas Bogendoerfer
2 siblings, 1 reply; 5+ messages in thread
From: Paul Cercueil @ 2021-03-07 19:28 UTC (permalink / raw)
To: Thomas Bogendoerfer, Rob Herring
Cc: od, dri-devel, devicetree, linux-kernel, linux-mips,
Paul Cercueil
The NT39016 panel is a fun beast, even though the documentation states
that the CS line is active-low, it will work just fine if the CS line is
configured as active-high, but it won't work if the CS line is forced
low or forced high.
Since it did actually work with the spi-cs-high property, this is not a
bugfix, but we should nonetheless remove that property to match the
documentation.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/mips/boot/dts/ingenic/gcw0.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts b/arch/mips/boot/dts/ingenic/gcw0.dts
index bc72304a2440..f4c04f2263ea 100644
--- a/arch/mips/boot/dts/ingenic/gcw0.dts
+++ b/arch/mips/boot/dts/ingenic/gcw0.dts
@@ -345,7 +345,6 @@ nt39016@0 {
spi-max-frequency = <3125000>;
spi-3wire;
- spi-cs-high;
reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS
2021-03-07 19:28 ` [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS Paul Cercueil
@ 2021-03-12 15:00 ` Thomas Bogendoerfer
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Bogendoerfer @ 2021-03-12 15:00 UTC (permalink / raw)
To: Paul Cercueil
Cc: Rob Herring, od, dri-devel, devicetree, linux-kernel, linux-mips
On Sun, Mar 07, 2021 at 07:28:30PM +0000, Paul Cercueil wrote:
> The NT39016 panel is a fun beast, even though the documentation states
> that the CS line is active-low, it will work just fine if the CS line is
> configured as active-high, but it won't work if the CS line is forced
> low or forced high.
>
> Since it did actually work with the spi-cs-high property, this is not a
> bugfix, but we should nonetheless remove that property to match the
> documentation.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/boot/dts/ingenic/gcw0.dts | 1 -
> 1 file changed, 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: panel/kingdisplay, kd035g6-54nt: Remove spi-cs-high
2021-03-07 19:28 [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high Paul Cercueil
2021-03-07 19:28 ` [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS Paul Cercueil
@ 2021-03-08 23:01 ` Rob Herring
2021-03-12 15:00 ` [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: " Thomas Bogendoerfer
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-03-08 23:01 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thomas Bogendoerfer, linux-mips, od, Rob Herring, devicetree,
dri-devel, linux-kernel
On Sun, 07 Mar 2021 19:28:29 +0000, Paul Cercueil wrote:
> The NT39016 panel is a fun beast, even though the documentation states
> that the CS line is active-low, it will work just fine if the CS line is
> configured as active-high, but it won't work if the CS line is forced
> low or forced high.
>
> Since it did actually work with the spi-cs-high property, this is not a
> bugfix, but we should nonetheless remove that property from the example
> to match the documentation.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high
2021-03-07 19:28 [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high Paul Cercueil
2021-03-07 19:28 ` [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS Paul Cercueil
2021-03-08 23:01 ` [PATCH 1/2] dt-bindings: panel/kingdisplay, kd035g6-54nt: Remove spi-cs-high Rob Herring
@ 2021-03-12 15:00 ` Thomas Bogendoerfer
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Bogendoerfer @ 2021-03-12 15:00 UTC (permalink / raw)
To: Paul Cercueil
Cc: Rob Herring, od, dri-devel, devicetree, linux-kernel, linux-mips
On Sun, Mar 07, 2021 at 07:28:29PM +0000, Paul Cercueil wrote:
> The NT39016 panel is a fun beast, even though the documentation states
> that the CS line is active-low, it will work just fine if the CS line is
> configured as active-high, but it won't work if the CS line is forced
> low or forced high.
>
> Since it did actually work with the spi-cs-high property, this is not a
> bugfix, but we should nonetheless remove that property from the example
> to match the documentation.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 1 -
> 1 file changed, 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-12 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-07 19:28 [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high Paul Cercueil
2021-03-07 19:28 ` [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS Paul Cercueil
2021-03-12 15:00 ` Thomas Bogendoerfer
2021-03-08 23:01 ` [PATCH 1/2] dt-bindings: panel/kingdisplay, kd035g6-54nt: Remove spi-cs-high Rob Herring
2021-03-12 15:00 ` [PATCH 1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: " Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).