From: David Miller <davem@davemloft.net>
To: zajec5@gmail.com
Cc: kuba@kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl
Subject: Re: [PATCH net-next 2/2] net: broadcom: bcm4908_enet: support TX interrupt
Date: Wed, 10 Mar 2021 15:45:38 -0800 (PST) [thread overview]
Message-ID: <20210310.154538.199786368593752214.davem@davemloft.net> (raw)
In-Reply-To: <20210310091410.10164-2-zajec5@gmail.com>
From: Rafał Miłecki <zajec5@gmail.com>
Date: Wed, 10 Mar 2021 10:14:10 +0100
>
> + if (enet->irq_tx >= 0) {
...
> + if (enet->irq_tx > 0) {
Tests are not consistent, please fix.
Thank you.
next prev parent reply other threads:[~2021-03-10 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:14 [PATCH net-next 1/2] dt-bindings: net: bcm4908-enet: add optional TX interrupt Rafał Miłecki
2021-03-10 9:14 ` [PATCH net-next 2/2] net: broadcom: bcm4908_enet: support " Rafał Miłecki
2021-03-10 23:45 ` David Miller [this message]
2021-03-11 12:35 ` [PATCH V2 net-next 1/2] dt-bindings: net: bcm4908-enet: add optional " Rafał Miłecki
2021-03-11 12:35 ` [PATCH V2 net-next 2/2] net: broadcom: bcm4908_enet: support " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310.154538.199786368593752214.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).