From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35241C433E0 for ; Wed, 10 Mar 2021 23:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3C5364FC3 for ; Wed, 10 Mar 2021 23:46:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233178AbhCJXqJ (ORCPT ); Wed, 10 Mar 2021 18:46:09 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46064 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbhCJXpn (ORCPT ); Wed, 10 Mar 2021 18:45:43 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 3CB7C4D0F5BA6; Wed, 10 Mar 2021 15:45:42 -0800 (PST) Date: Wed, 10 Mar 2021 15:45:38 -0800 (PST) Message-Id: <20210310.154538.199786368593752214.davem@davemloft.net> To: zajec5@gmail.com Cc: kuba@kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl Subject: Re: [PATCH net-next 2/2] net: broadcom: bcm4908_enet: support TX interrupt From: David Miller In-Reply-To: <20210310091410.10164-2-zajec5@gmail.com> References: <20210310091410.10164-1-zajec5@gmail.com> <20210310091410.10164-2-zajec5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=euc-kr Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Wed, 10 Mar 2021 15:45:42 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Rafaİİ Miİİecki Date: Wed, 10 Mar 2021 10:14:10 +0100 > > + if (enet->irq_tx >= 0) { ... > + if (enet->irq_tx > 0) { Tests are not consistent, please fix. Thank you.