From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B761FC433DB for ; Wed, 10 Mar 2021 03:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C50D64FEE for ; Wed, 10 Mar 2021 03:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbhCJDpt (ORCPT ); Tue, 9 Mar 2021 22:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232191AbhCJDpV (ORCPT ); Tue, 9 Mar 2021 22:45:21 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A231DC061760 for ; Tue, 9 Mar 2021 19:45:20 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id j6so7796266plx.6 for ; Tue, 09 Mar 2021 19:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DhWQQNXXhBl9V6m34E/2PgUYDDDOUR9yglVAy9KAsHY=; b=wZtFlrFINw2Eair2VU4xp47Y+Zi2XmPCnVs7/PeQQ+qZL4KJz7TIbM4fSs7rkGdkWR Tl0SPi8DxbMK8n35d2WfRZLLZq4vPNMNMHbSFMmDEzlJFbNrHYjyFJSXibqvB6mvIPuD rujaYePPrZWDrQl7ZM7yyKgguW+gm+ZdWMmhJdy5CCVN12yHflTVRMooqqaZjBXgX9Kt cAmLiJrc1A1N7FR0ipezYhyPkO0X/Y7qlZyQlyR8kFhaSqV47S6YisodCt2dGdZPBJfi 7LkD7ptdMN+fdaTf4amIBaL5YBjSVwYLMZjIj0Yz5VYlgXYqGz9aqnewwYhzjiUJKmF8 xJZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DhWQQNXXhBl9V6m34E/2PgUYDDDOUR9yglVAy9KAsHY=; b=DLzCVH3WQAtt79yvKk+TORWuh+q5NoaF2yD82NirXPfj4v2XiKhOX0MkphQRR0b/TH R4ad7zEhK4mixNqJNHCItMbz6qF/5qIm+JGjeRsoNRJjlE3yYC7Jm3Ke5zqoeYcTZEev mVeTHdTdKIWhnD43TFW63lNDljoyTY8Gm8QjDeDNPWRZW/agyKacOaSikun6688KDyGx T+Km52TPIjAHyfEs6Mdk4/BliiIiZLZVQ0w0d5D6XBBcoY367+kpS32I+xPNdjmlgzTQ TD62sFv1KTojWZnn3QFGl5JORn/sFh6WHTSt5kGOfLSkRDQId1/a2PVMJJzYf1r58Mas nbJQ== X-Gm-Message-State: AOAM532GfWhH7dfdWMINzmonSGQWUolXJCPk50NKF4QJ5SDu+8HaSI8d xcXPnDx5lvbBUpYrSVqtEb53 X-Google-Smtp-Source: ABdhPJww3LXcQIsgNxaSJHDT5/xWPeMIY19nocTKUL5cDKhnuEj6JBzU0U6CZYxIYaCnJ0FAoncP0w== X-Received: by 2002:a17:902:d114:b029:e4:87c7:39f5 with SMTP id w20-20020a170902d114b02900e487c739f5mr988931plw.72.1615347919127; Tue, 09 Mar 2021 19:45:19 -0800 (PST) Received: from work ([103.66.79.59]) by smtp.gmail.com with ESMTPSA id l2sm2149788pji.45.2021.03.09.19.45.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Mar 2021 19:45:18 -0800 (PST) Date: Wed, 10 Mar 2021 09:15:14 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: =?iso-8859-1?Q?Miqu=E8l?= Raynal , Richard Weinberger , Vignesh R , linux-arm-msm , MTD Maling List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Boris Brezillon Subject: Re: [PATCH 2/3] dt-bindings: mtd: Add a property to declare secure regions in Qcom NANDc Message-ID: <20210310034514.GA11114@work> References: <20210222120259.94465-1-manivannan.sadhasivam@linaro.org> <20210222120259.94465-3-manivannan.sadhasivam@linaro.org> <20210305233657.GA839767@robh.at.kernel.org> <20210308053140.GA5457@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 09, 2021 at 07:32:28PM -0700, Rob Herring wrote: > On Sun, Mar 7, 2021 at 10:31 PM Manivannan Sadhasivam > wrote: > > > > On Fri, Mar 05, 2021 at 05:36:57PM -0600, Rob Herring wrote: > > > On Mon, Feb 22, 2021 at 05:32:58PM +0530, Manivannan Sadhasivam wrote: > > > > On a typical end product, a vendor may choose to secure some regions in > > > > the NAND memory which are supposed to stay intact between FW upgrades. > > > > The access to those regions will be blocked by a secure element like > > > > Trustzone. So the normal world software like Linux kernel should not > > > > touch these regions (including reading). > > > > > > > > So let's add a property for declaring such secure regions so that the > > > > driver can skip touching them. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > Documentation/devicetree/bindings/mtd/qcom,nandc.yaml | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml > > > > index 84ad7ff30121..7500e20da9c1 100644 > > > > --- a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml > > > > +++ b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml > > > > @@ -48,6 +48,13 @@ patternProperties: > > > > enum: > > > > - 512 > > > > > > > > + qcom,secure-regions: > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > > > Don't you need 64-bit regions potentially? Though 4GB should be enough > > > for anyone. > > > > > > > Yes, given the size of current NAND based systems around, I thought 32 bit is > > enough. > > Huh!? I was joking. 4GB is small nowadays. Make this 64-bit. > Well I was speaking in the context of Qcom chipsets making use of NAND. Mostly the Qcom modem chipsets have <4GB of memory. But since this property is now not specific to Qcom, I agree with you and will make it 64 bit. Thanks, Mani > Rob