From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39611C433E9 for ; Wed, 10 Mar 2021 10:41:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5C8E64FF7 for ; Wed, 10 Mar 2021 10:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbhCJKlT (ORCPT ); Wed, 10 Mar 2021 05:41:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231492AbhCJKlD (ORCPT ); Wed, 10 Mar 2021 05:41:03 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80C66C061760 for ; Wed, 10 Mar 2021 02:41:03 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id v15so22756147wrx.4 for ; Wed, 10 Mar 2021 02:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=WkEYLNZKWBGlnhJh5/km8rZ3DoQwSCNLt1pwHkgN/WY=; b=mHQYTozuc0TTEvwola4UDXnujaWX5hjYQa9oyx2Km6taceH5yU6itTe3PHtZRoodFk PcpDyrzEdhly/3+4FAgeUEG40pSos2nmuPn1KTn0DaKzmxXkOLlhaSMgX3xY0TP5yGho XUAGxYyDak/7+4NtvRj+ZYLT5U1J2/9BlGZ3cDktu+mUvRsohm8uzz6kt2LvcNFTcmIJ iLoeMXyTF9AvGdP4MtkZmWxddvxG8KX8rGFLE97/3fMt941pJ/GCNgLhf3sq73X85KMT ZvEMyGQ06vuK16Gnxi7/pPa0ZujXMlI26tTXN4iq9PCwUotcEIAVxQcOPv9rOzFR0PW4 Q9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WkEYLNZKWBGlnhJh5/km8rZ3DoQwSCNLt1pwHkgN/WY=; b=IyGzRwYXaPIWR9e/As5UB70EEhr+hPtwx4SzZJJRnDgIpFazH1RcjV6GQJ951u4O7p jqHjuwMJPxXHO0DIUiqdBiZ9RTkpS5leBJVPVTYsno8btUHPvmyoq9HhvHp4mm9/mS/z 0uzrWVLoyO8kpTqNRH+FllBW6rjO8REt2/Wz7DGHfMxsBdVJEUBHyqY4wHLHKSo/JoUT X7HLTgLqtJEWKNRysr6BNiXRPRy+2rIz9l31gv9UT785lUsFiwhYccc51g4FODJwiacn fgB4Ga77lrXsjqv1pEp83RpF9E6NEqQrei9doF5y3lgCPRVPC1o0HTNOrDOVicIWRgc6 6aDg== X-Gm-Message-State: AOAM532ZvPdLfHKYL4oqTaF789mhaU4j1KckWP1lG1TcsyxdpdVC1xzc hkcuor1RGQ0cEnWfLlTclRt7KQ== X-Google-Smtp-Source: ABdhPJxwjavMwOHE+n1ODwYYFNhz44dTAKmAcPmhdGkziT2QVK5lAqeefbljMchSOuIx6t1sYrSA2w== X-Received: by 2002:adf:fecc:: with SMTP id q12mr2761099wrs.317.1615372862210; Wed, 10 Mar 2021 02:41:02 -0800 (PST) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id x11sm8453405wmi.3.2021.03.10.02.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 02:41:01 -0800 (PST) Date: Wed, 10 Mar 2021 10:40:58 +0000 From: Lee Jones To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Rob Herring , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v3 07/15] mfd: Support for ROHM BD71815 PMIC core Message-ID: <20210310104058.GH701493@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 08 Mar 2021, Matti Vaittinen wrote: > Add core support for ROHM BD71815 Power Management IC. > > The IC integrates regulators, a battery charger with a coulomb counter, > a real-time clock (RTC), clock gate and general-purpose outputs (GPO). > > Signed-off-by: Matti Vaittinen > --- > Changes since v2: > - styling / clean-ups suggested by Lee > - corrected clk-mode dt property values to match changed bindings > > drivers/mfd/Kconfig | 15 +- > drivers/mfd/rohm-bd71828.c | 486 +++++++++++++++++++------- > include/linux/mfd/rohm-bd71815.h | 563 +++++++++++++++++++++++++++++++ > include/linux/mfd/rohm-bd71828.h | 3 + > 4 files changed, 934 insertions(+), 133 deletions(-) > create mode 100644 include/linux/mfd/rohm-bd71815.h [...] > diff --git a/include/linux/mfd/rohm-bd71815.h b/include/linux/mfd/rohm-bd71815.h > new file mode 100644 > index 000000000000..9927aadac234 > --- /dev/null > +++ b/include/linux/mfd/rohm-bd71815.h > @@ -0,0 +1,563 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Nit: If you rework this for any reason, please remove this line. For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog