Re: [PATCH v1 2/2] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2990 bytes --]

Hi Yongqiang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc2 next-20210310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yongqiang-Niu/Revert-mailbox-mediatek-remove-implementation-related-to-atomic_exec/20210310-154512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 05a59d79793d482f628a31753c671f2e92178a21
config: microblaze-randconfig-r011-20210308 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/876bcec7aee51ac5f6f0697523f91a72b85d6a5d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yongqiang-Niu/Revert-mailbox-mediatek-remove-implementation-related-to-atomic_exec/20210310-154512
        git checkout 876bcec7aee51ac5f6f0697523f91a72b85d6a5d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mailbox/mtk-cmdq-mailbox.c: In function 'cmdq_task_insert_into_thread':
>> drivers/mailbox/mtk-cmdq-mailbox.c:173:21: error: 'cmdq' undeclared (first use in this function)
     173 |   (task->pa_base >> cmdq->shift_pa);
         |                     ^~~~
   drivers/mailbox/mtk-cmdq-mailbox.c:173:21: note: each undeclared identifier is reported only once for each function it appears in


vim +/cmdq +173 drivers/mailbox/mtk-cmdq-mailbox.c

   159	
   160	static void cmdq_task_insert_into_thread(struct cmdq_task *task)
   161	{
   162		struct device *dev = task->cmdq->mbox.dev;
   163		struct cmdq_thread *thread = task->thread;
   164		struct cmdq_task *prev_task = list_last_entry(
   165				&thread->task_busy_list, typeof(*task), list_entry);
   166		u64 *prev_task_base = prev_task->pkt->va_base;
   167	
   168		/* let previous task jump to this task */
   169		dma_sync_single_for_cpu(dev, prev_task->pa_base,
   170					prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
   171		prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
   172			(u64)CMDQ_JUMP_BY_PA << 32 |
 > 173			(task->pa_base >> cmdq->shift_pa);
   174		dma_sync_single_for_device(dev, prev_task->pa_base,
   175					   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
   176	
   177		cmdq_thread_invalidate_fetched_data(thread);
   178	}
   179	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31533 bytes --]