devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Bajjuri, Praneeth" <praneeth@ti.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, Tero Kristo <kristo@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry
Date: Thu, 11 Mar 2021 06:56:34 -0600	[thread overview]
Message-ID: <20210311125634.sasiot7hemsdcajl@thrash> (raw)
In-Reply-To: <9097f361-419f-995f-2f05-d17a949af1cb@ti.com>

On 19:36-20210310, Bajjuri, Praneeth wrote:
> 
> 
> On 2/20/2021 6:49 AM, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > Add the DT entry for a watchdog based on RTI1.
> > 
> > On SR1.0 silicon, it requires additional firmware on the MCU R5F cores
> > to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As
> > this firmware will also lock the power domain to protect it against
> > premature shutdown, mark it shared.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Acked-by: Praneeth Bajjuri <praneeth@ti.com>
> 
> > ---
> >   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > index 7454c8cec0cc..903796bf7d64 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 {
> >   			ti,loczrama = <1>;
> >   		};
> >   	};
> > +
> > +	mcu_rti1: rti@40610000 {

Jan, I was about to pick up the patches and was running through
my sanity checks and the following caught my eye with dtbs_check
(dtschema is at 2021.2.1) test against next-20210311

/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: rti@40610000: $nodename:0: 'rti@40610000' does not match '^watchdog(@.*|-[0-9a-f])?$'

Please use watchdog@40610000 instead of rti@40610000

Since this is a minor change, I have done this change locally. let me
know if you have an issue and I can drop it off my branch for a new
version.

[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2021-03-11 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-20 12:49 [PATCH] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry Jan Kiszka
2021-03-11  1:36 ` Bajjuri, Praneeth
2021-03-11 12:56   ` Nishanth Menon [this message]
2021-03-11 13:01     ` Jan Kiszka
2021-03-11 14:15 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311125634.sasiot7hemsdcajl@thrash \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@web.de \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).