From: Nishanth Menon <nm@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Le Jin <le.jin@siemens.com>,
Bao Cheng Su <baocheng.su@siemens.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v4 3/3] arm64: dts: ti: Add support for Siemens IOT2050 boards
Date: Thu, 11 Mar 2021 07:17:54 -0600 [thread overview]
Message-ID: <20210311131754.i5ewls6hgeitcgre@astonish> (raw)
In-Reply-To: <9bff40f434e5298890e5d139cc36cc46a0ca2d76.1615369068.git.jan.kiszka@siemens.com>
On 10:37-20210310, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> + spidev@0 {
> + compatible = "rohm,dh2228fv";
> + spi-max-frequency = <20000000>;
> + reg = <0>;
Jan,
As part of my final sanity checks, I noticed that we missed this: is a checkpatch warning
WARNING: DT compatible string "rohm,dh2228fv" appears un-documented -- check ./Documentation/devicetree/bindings/
#629: FILE: arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi:581:
compatible = "rohm,dh2228fv";
I cannot pick up nodes that are'nt documented as yaml in
Documentation/devicetree
I know this is irritating to find such nodes that already have previous
users and the person coming last gets to deal with "new rules".. but
sorry for catching this so late.
Here are the options that come to mind:
option 1) - drop the node and resubmit.
option 2) - get the documentation into linux master tree and then submit
the patches.
I think we should just drop the node and resubmit - since this is a more
intrusive change and I don't have your platform handy, I am going to
suggest you make a call :(
Additionally please install yamlint and dtbs_schema -> run dtbs_check. I
see more than a few warnings there which may need some closer look.
A full log against linux-next is here: https://pastebin.ubuntu.com/p/qR69h28c5f/
PS: https://github.com/nmenon/kernel_patch_verify/blob/master/kpv
I have been using my script to verify with kpv -C -V -n num_patches and
then digging through the logs.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-03-11 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:37 [PATCH v4 0/3] arm64: Add TI AM65x-based IOT2050 boards Jan Kiszka
2021-03-10 9:37 ` [PATCH v4 1/3] dt-bindings: Add Siemens vendor prefix Jan Kiszka
2021-03-10 9:37 ` [PATCH v4 2/3] dt-bindings: arm: ti: Add bindings for Siemens IOT2050 boards Jan Kiszka
2021-03-10 9:37 ` [PATCH v4 3/3] arm64: dts: ti: Add support " Jan Kiszka
2021-03-11 13:17 ` Nishanth Menon [this message]
2021-03-11 13:44 ` Jan Kiszka
2021-03-11 14:00 ` Nishanth Menon
2021-03-11 14:14 ` Jan Kiszka
2021-03-11 14:21 ` Nishanth Menon
2021-03-11 14:36 ` Jan Kiszka
2021-03-11 17:56 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311131754.i5ewls6hgeitcgre@astonish \
--to=nm@ti.com \
--cc=baocheng.su@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=le.jin@siemens.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).