From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE711C43381 for ; Mon, 15 Mar 2021 21:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0BB264F4C for ; Mon, 15 Mar 2021 21:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233176AbhCOVjq (ORCPT ); Mon, 15 Mar 2021 17:39:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26106 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233135AbhCOVjo (ORCPT ); Mon, 15 Mar 2021 17:39:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615844383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkdqntrkesd0zsgt86ODqpue66pp2ATokoiM4RMTzrY=; b=Chfa3PvWs5O4zRX4PlHcKESA6pFb/b1MNotXWcqXVoDy27gSxaVmK0dg0TvO7zBlqFvtGH D1DhRzK8V7YYgLSzzLwU2UpY/MttT9wg1vm/grZGRYzURU3B+a58NOcyIJIAMqm7EOIkF7 I/uxCmHcL4Phu4gDKeKRIG62JVBLyCM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-Sj3oSMX9MzyFVnnvkG8hOQ-1; Mon, 15 Mar 2021 17:39:39 -0400 X-MC-Unique: Sj3oSMX9MzyFVnnvkG8hOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C52CF87A83A; Mon, 15 Mar 2021 21:39:37 +0000 (UTC) Received: from localhost (unknown [10.10.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id A83145C3E6; Mon, 15 Mar 2021 21:39:34 +0000 (UTC) Date: Mon, 15 Mar 2021 14:39:33 -0700 (PDT) Message-Id: <20210315.143933.939938434416308507.davem@redhat.com> To: cristian.ciocaltea@gmail.com Cc: andrew@lunn.ch, kuba@kernel.org, robh+dt@kernel.org, afaerber@suse.de, mani@kernel.org, p.zabel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver From: David Miller In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Cristian Ciocaltea Date: Mon, 15 Mar 2021 13:29:17 +0200 > + > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK) > +static int debug = -1; > +module_param(debug, int, 0); > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); Module parameters are strongly discouraged in networking drivers, pplease delete this ad just pass the default to netif_mdg_init(), thanks!