From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507B4C433E0 for ; Mon, 15 Mar 2021 07:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F54864E44 for ; Mon, 15 Mar 2021 07:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbhCOHD2 (ORCPT ); Mon, 15 Mar 2021 03:03:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:57138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbhCOHDU (ORCPT ); Mon, 15 Mar 2021 03:03:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 364EE64E21; Mon, 15 Mar 2021 07:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615791800; bh=FqvtiBmaPgRyCbg789nS04VcPbAIilsWOT16ZGjk9i8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IOMbEGrnwOQ0Q9w9QPITOt2U0hjfdkeucHkDjJ+mup8CSu5Jji1XyB2/ih7pc/HNH 2P6+Qr8OgZSQNuYoBaVQvMoWRUkYwhBJ8Xm/olbzeW7B65RGlOqTZ7gvwjaR0KcjPj zAZ/yMPGvFI8KrTu8ZMQ68QkC2+fJJ2bGQNge5L5N0jUiDcNotkXfSz9IODyjR7Xzj REWUVQFYZ+LQ2niMO4R8V91Fh679IJg/9tFuPIHsRO8ah+yqZ7Gz6k1HSUWiELWXwW xqcDz35oDUwBRGtJl9z8kz81QCjkfsiiA9pLCKgiOiVDw+BKeB61PELAtBYsq9p7yh EZRYgTGaV6b7Q== Date: Mon, 15 Mar 2021 15:03:15 +0800 From: Shawn Guo To: Russell King Cc: Li Yang , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Jon Nettleton Subject: Re: [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*] Message-ID: <20210315070314.GN11246@dragon> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 09, 2021 at 04:36:58PM +0000, Russell King wrote: > Add 2x2 SFP+ cage support for clearfog-itx boards. > > Signed-off-by: Russell King What is the implication of [*experimental*] in subject? Shawn > --- > .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi | 24 +++++++ > .../freescale/fsl-lx2160a-clearfog-itx.dtsi | 64 +++++++++++++++++++ > 2 files changed, 88 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi > index 459dccad8326..afb455210bd0 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi > @@ -122,6 +122,30 @@ > vcc-supply = <&sb_3v3>; > }; > }; > + > + sfp0_i2c: i2c@4 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <4>; > + }; > + > + sfp1_i2c: i2c@5 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <5>; > + }; > + > + sfp2_i2c: i2c@6 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <6>; > + }; > + > + sfp3_i2c: i2c@7 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <7>; > + }; > }; > }; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi > index 2b63235ca627..17f8e733972a 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi > @@ -30,6 +30,54 @@ > gpios = <&gpio2 6 GPIO_ACTIVE_LOW>; > }; > }; > + > + sfp0: sfp-0 { > + compatible = "sff,sfp"; > + i2c-bus = <&sfp0_i2c>; > + mod-def0-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>; > + maximum-power-milliwatt = <2000>; > + }; > + > + sfp1: sfp-1 { > + compatible = "sff,sfp"; > + i2c-bus = <&sfp1_i2c>; > + mod-def0-gpio = <&gpio2 9 GPIO_ACTIVE_LOW>; > + maximum-power-milliwatt = <2000>; > + }; > + > + sfp2: sfp-2 { > + compatible = "sff,sfp"; > + i2c-bus = <&sfp2_i2c>; > + mod-def0-gpio = <&gpio2 10 GPIO_ACTIVE_LOW>; > + maximum-power-milliwatt = <2000>; > + }; > + > + sfp3: sfp-3 { > + compatible = "sff,sfp"; > + i2c-bus = <&sfp3_i2c>; > + mod-def0-gpio = <&gpio2 11 GPIO_ACTIVE_LOW>; > + maximum-power-milliwatt = <2000>; > + }; > +}; > + > +&dpmac7 { > + sfp = <&sfp0>; > + managed = "in-band-status"; > +}; > + > +&dpmac8 { > + sfp = <&sfp1>; > + managed = "in-band-status"; > +}; > + > +&dpmac9 { > + sfp = <&sfp2>; > + managed = "in-band-status"; > +}; > + > +&dpmac10 { > + sfp = <&sfp3>; > + managed = "in-band-status"; > }; > > &emdio2 { > @@ -44,6 +92,22 @@ > status = "okay"; > }; > > +&pcs_mdio7 { > + status = "okay"; > +}; > + > +&pcs_mdio8 { > + status = "okay"; > +}; > + > +&pcs_mdio9 { > + status = "okay"; > +}; > + > +&pcs_mdio10 { > + status = "okay"; > +}; > + > &sata0 { > status = "okay"; > }; > -- > 2.20.1 >