From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C19AC433E0 for ; Mon, 15 Mar 2021 21:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32AE264F4A for ; Mon, 15 Mar 2021 21:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbhCOVKY (ORCPT ); Mon, 15 Mar 2021 17:10:24 -0400 Received: from mga06.intel.com ([134.134.136.31]:11014 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234094AbhCOVJy (ORCPT ); Mon, 15 Mar 2021 17:09:54 -0400 IronPort-SDR: fXsgOweZYP95NAO+zFJR/ZlHkZZwV8OeAeCZJ862URrHJAufW7idKaSYpDHO4fJprjS/liQXOe KObCPPVjNPqA== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="250521755" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="250521755" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 14:09:51 -0700 IronPort-SDR: QqoGwGyIM0SWmD7Q9R5vG3zx01mNrOXrhviDksM4WCW0VuB8g8mlBMbiH48KGyKc4ek6oMVHt9 3YUhURq5KwEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="601571804" Received: from lkp-server02.sh.intel.com (HELO 1dc5e1a854f4) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 15 Mar 2021 14:09:48 -0700 Received: from kbuild by 1dc5e1a854f4 with local (Exim 4.92) (envelope-from ) id 1lLuTE-0000eY-AL; Mon, 15 Mar 2021 21:09:48 +0000 Date: Tue, 16 Mar 2021 05:09:20 +0800 From: kernel test robot To: Jerome Pouiller , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kbuild-all@lists.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , devicetree@vger.kernel.org, Rob Herring , linux-mmc@vger.kernel.org Subject: [PATCH] wfx: fix irqf_oneshot.cocci warnings Message-ID: <20210315210920.GA43634@d108da9836c5> References: <20210315132501.441681-25-Jerome.Pouiller@silabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210315132501.441681-25-Jerome.Pouiller@silabs.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: kernel test robot drivers/net/wireless/silabs/wfx/bus_sdio.c:134:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Jérôme Pouiller Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Jerome-Pouiller/wfx-get-out-from-the-staging-area/20210315-212855 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git b828324bba8f575fde487a91fec07303789dda8a bus_sdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/wireless/silabs/wfx/bus_sdio.c +++ b/drivers/net/wireless/silabs/wfx/bus_sdio.c @@ -132,7 +132,8 @@ static int wfx_sdio_irq_subscribe(void * flags = IRQF_TRIGGER_HIGH; flags |= IRQF_ONESHOT; return devm_request_threaded_irq(&bus->func->dev, bus->of_irq, NULL, - wfx_sdio_irq_handler_ext, flags, + wfx_sdio_irq_handler_ext, + flags | IRQF_ONESHOT, "wfx", bus); }