From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2605EC433DB for ; Fri, 19 Mar 2021 16:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA2CE6194E for ; Fri, 19 Mar 2021 16:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbhCSQ5S (ORCPT ); Fri, 19 Mar 2021 12:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbhCSQ5E (ORCPT ); Fri, 19 Mar 2021 12:57:04 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E31FC06174A; Fri, 19 Mar 2021 09:57:04 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id ABD581F46C3F; Fri, 19 Mar 2021 16:57:02 +0000 (GMT) Date: Fri, 19 Mar 2021 17:56:59 +0100 From: Boris Brezillon To: Manivannan Sadhasivam Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Daniele.Palmas@telit.com, bjorn.andersson@linaro.org Subject: Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory Message-ID: <20210319175659.17c9e8e6@collabora.com> In-Reply-To: <20210319150010.32122-4-manivannan.sadhasivam@linaro.org> References: <20210319150010.32122-1-manivannan.sadhasivam@linaro.org> <20210319150010.32122-4-manivannan.sadhasivam@linaro.org> Organization: Collabora X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 19 Mar 2021 20:30:10 +0530 Manivannan Sadhasivam wrote: > @@ -2737,6 +2783,11 @@ static int nand_read_page_swecc(struct nand_chip *chip, uint8_t *buf, > uint8_t *ecc_code = chip->ecc.code_buf; > unsigned int max_bitflips = 0; > > + /* Check if the region is secured */ > + ret = nand_check_secure_region(chip, ((loff_t)page << chip->page_shift), 0); > + if (ret) > + return ret; > + I'm lost. Why do you need to do that here if it's already done in nand_do_read_{ops,oob}()? > chip->ecc.read_page_raw(chip, buf, 1, page); > > for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)