From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC3CC433DB for ; Sat, 20 Mar 2021 03:06:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B73ED61985 for ; Sat, 20 Mar 2021 03:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbhCTDFt (ORCPT ); Fri, 19 Mar 2021 23:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbhCTDFd (ORCPT ); Fri, 19 Mar 2021 23:05:33 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D203C061762 for ; Fri, 19 Mar 2021 20:05:33 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id il9-20020a17090b1649b0290114bcb0d6c2so300053pjb.0 for ; Fri, 19 Mar 2021 20:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Em6lpjRfJTbiYdVSiA1ppSbjAUxMrhzU5Ds1dTYJXe8=; b=w3OoCnPNXittE8wi/EHalhW9k1I9VETut3jNvP5lq9QA744ELqa2aUkDKmJwq9l+zP KKh18KKa7Nawwzmw3JpkOnmE8eXOTrqF0s/DlEQzh3WhJtIyOUqEuOiFvhlHmg911eYY pXZJ8z2v0cO7Z+XP1XGuJ7ht3mSrfE9SCgLdIeIPvJMUeCjfZvYGoRHd+dW4z+pGsOkR 30z2UZNNjGq1WZddd6B3Z28jeGVpwv+VXq4C0FHYBHQQ13/+NRWzSMpioCTtka/MNPXO GE6qnjq/9FOdpRPCy7ho7sL14KFAyuilWJUA8afzHLGnTgENcZjuSbx7Qh96JTglW1b7 iz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Em6lpjRfJTbiYdVSiA1ppSbjAUxMrhzU5Ds1dTYJXe8=; b=WKWakwJc0qGSIXvwmMjOWjkD+iJeYO5JdPLoMobck7OH15P03Aq+rTic+aK+WgCWDE l4b+o+BrGn+GRwDShqcI+sH5U8I4bwoRnwWeVvOzHtALuYMnGIXy0Tphf5E09etklQKw W0ChmhrAZiSo5fR/9aOYt2ZJWvOJOtdaKHmgDDZOBwIQ52PX+n+pTTZK47RsB91Hf/bG o4wzPfBEjhkZm74hn5GaNz17rheTAkKGc19SYZwwatWdCnt3bqIRxKN8DjLr3AsK2U3c qWoGiW2tgoiakbO8GKfJZzpPxWCK1GYXOKDzNSiTkIKz5fK5Gdoh1UP/Aoy10wYpDh/+ PUSg== X-Gm-Message-State: AOAM532cShTGyHKf8ARvlLppTx5sSc0UgGLgLV3rAo+3/aHX36Ff+Da3 iYplsP4kriUT/elzF/GdNZDwZQUOIp+mdHb+Wbg= X-Google-Smtp-Source: ABdhPJwSQDMHwF6dvSvGGyqfyHQF2o7+RnnBuuJrW8/PeWhQemdRuw4bSMTpMylMQSGpf0thCIFMOw== X-Received: by 2002:a17:90a:c257:: with SMTP id d23mr1606185pjx.102.1616209532943; Fri, 19 Mar 2021 20:05:32 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([116.206.101.226]) by smtp.gmail.com with ESMTPSA id v1sm6178974pgh.17.2021.03.19.20.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 20:05:32 -0700 (PDT) Date: Sat, 20 Mar 2021 11:05:28 +0800 From: Leo Yan To: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Coresight ML , Mike Leach Cc: Georgi Djakov Subject: Re: [PATCH] arm64: dts: msm8916: Enable CoreSight STM component Message-ID: <20210320030528.GA488187@leoy-ThinkPad-X240s> References: <20210320025942.487916-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320025942.487916-1-leo.yan@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Mike, On Sat, Mar 20, 2021 at 10:59:42AM +0800, Leo Yan wrote: > From: Georgi Djakov > > Add DT binding for CoreSight System Trace Macrocell (STM) on msm8916, > which can benefit the CoreSight development on DB410c. For the DT binding for CoreSight STM on DB410c, I have one question: Do you know there have any CTI is conntected to STM so that the DT binding needs to reflect the connection? If this is the case, we should update the DT binding for CTI node as well. Thanks, Leo > > Signed-off-by: Georgi Djakov > Signed-off-by: Leo Yan > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 + > arch/arm64/boot/dts/qcom/msm8916.dtsi | 27 +++++++++++++++++++++++ > 2 files changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > index 3a9538e1ec97..dd87e5d739ab 100644 > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > @@ -406,6 +406,7 @@ &wcd_codec { > &etm1 { status = "okay"; }; > &etm2 { status = "okay"; }; > &etm3 { status = "okay"; }; > +&stm { status = "okay"; }; > &etr { status = "okay"; }; > &funnel0 { status = "okay"; }; > &funnel1 { status = "okay"; }; > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 402e891a84ab..892f1772e53c 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -562,6 +562,13 @@ funnel0_in4: endpoint { > remote-endpoint = <&funnel1_out>; > }; > }; > + > + port@7 { > + reg = <7>; > + funnel0_in7: endpoint { > + remote-endpoint = <&stm_out>; > + }; > + }; > }; > > out-ports { > @@ -882,6 +889,26 @@ etm3_out: endpoint { > }; > }; > > + stm: stm@802000 { > + compatible = "arm,coresight-stm", "arm,primecell"; > + reg = <0x802000 0x1000>, > + <0x9280000 0x180000>; > + reg-names = "stm-base", "stm-stimulus-base"; > + > + clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>; > + clock-names = "apb_pclk", "atclk"; > + > + status = "disabled"; > + > + out-ports { > + port { > + stm_out: endpoint { > + remote-endpoint = <&funnel0_in7>; > + }; > + }; > + }; > + }; > + > msmgpio: pinctrl@1000000 { > compatible = "qcom,msm8916-pinctrl"; > reg = <0x01000000 0x300000>; > -- > 2.25.1 >