Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6610 bytes --]

Hi Liu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on robh/for-next drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12-rc3 next-20210319]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Liu-Ying/Add-some-DRM-bridge-drivers-support-for-i-MX8qm-qxp-SoCs/20210317-115847
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/482264f815494bc2e90bde5f7b47a60331b81817
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Liu-Ying/Add-some-DRM-bridge-drivers-support-for-i-MX8qm-qxp-SoCs/20210317-115847
        git checkout 482264f815494bc2e90bde5f7b47a60331b81817
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:65:16: warning: 'struct phy_configure_opts_lvds' declared inside parameter list will not be visible outside of this definition or declaration
      65 |         struct phy_configure_opts_lvds *phy_cfg)
         |                ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c: In function 'imx8qxp_ldb_set_phy_cfg':
>> drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:67:9: error: dereferencing pointer to incomplete type 'struct phy_configure_opts_lvds'
      67 |  phy_cfg->bits_per_lane_and_dclk_cycle = 7;
         |         ^~
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c: In function 'imx8qxp_ldb_bridge_atomic_check':
>> drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:94:49: error: 'union phy_configure_opts' has no member named 'lvds'
      94 |  struct phy_configure_opts_lvds *phy_cfg = &opts.lvds;
         |                                                 ^
>> drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:102:57: error: passing argument 4 of 'imx8qxp_ldb_set_phy_cfg' from incompatible pointer type [-Werror=incompatible-pointer-types]
     102 |  imx8qxp_ldb_set_phy_cfg(imx8qxp_ldb, di_clk, is_split, phy_cfg);
         |                                                         ^~~~~~~
         |                                                         |
         |                                                         struct phy_configure_opts_lvds *
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:65:41: note: expected 'struct phy_configure_opts_lvds *' but argument is of type 'struct phy_configure_opts_lvds *'
      65 |         struct phy_configure_opts_lvds *phy_cfg)
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c: In function 'imx8qxp_ldb_bridge_mode_set':
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:136:49: error: 'union phy_configure_opts' has no member named 'lvds'
     136 |  struct phy_configure_opts_lvds *phy_cfg = &opts.lvds;
         |                                                 ^
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:162:57: error: passing argument 4 of 'imx8qxp_ldb_set_phy_cfg' from incompatible pointer type [-Werror=incompatible-pointer-types]
     162 |  imx8qxp_ldb_set_phy_cfg(imx8qxp_ldb, di_clk, is_split, phy_cfg);
         |                                                         ^~~~~~~
         |                                                         |
         |                                                         struct phy_configure_opts_lvds *
   drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:65:41: note: expected 'struct phy_configure_opts_lvds *' but argument is of type 'struct phy_configure_opts_lvds *'
      65 |         struct phy_configure_opts_lvds *phy_cfg)
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
   cc1: some warnings being treated as errors


vim +67 drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c

    62	
    63	static void imx8qxp_ldb_set_phy_cfg(struct imx8qxp_ldb *imx8qxp_ldb,
    64					    unsigned long di_clk, bool is_split,
    65					    struct phy_configure_opts_lvds *phy_cfg)
    66	{
  > 67		phy_cfg->bits_per_lane_and_dclk_cycle = 7;
    68		phy_cfg->lanes = 4;
    69	
    70		if (is_split) {
    71			phy_cfg->differential_clk_rate = di_clk / 2;
    72			phy_cfg->is_slave = !imx8qxp_ldb->companion;
    73		} else {
    74			phy_cfg->differential_clk_rate = di_clk;
    75			phy_cfg->is_slave = false;
    76		}
    77	}
    78	
    79	static int imx8qxp_ldb_bridge_atomic_check(struct drm_bridge *bridge,
    80					   struct drm_bridge_state *bridge_state,
    81					   struct drm_crtc_state *crtc_state,
    82					   struct drm_connector_state *conn_state)
    83	{
    84		struct ldb_channel *ldb_ch = bridge->driver_private;
    85		struct ldb *ldb = ldb_ch->ldb;
    86		struct imx8qxp_ldb_channel *imx8qxp_ldb_ch =
    87						base_to_imx8qxp_ldb_channel(ldb_ch);
    88		struct imx8qxp_ldb *imx8qxp_ldb = base_to_imx8qxp_ldb(ldb);
    89		struct drm_bridge *companion = imx8qxp_ldb->companion;
    90		struct drm_display_mode *adj = &crtc_state->adjusted_mode;
    91		unsigned long di_clk = adj->clock * 1000;
    92		bool is_split = ldb_channel_is_split_link(ldb_ch);
    93		union phy_configure_opts opts = { };
  > 94		struct phy_configure_opts_lvds *phy_cfg = &opts.lvds;
    95		int ret;
    96	
    97		ret = ldb_bridge_atomic_check_helper(bridge, bridge_state,
    98							crtc_state, conn_state);
    99		if (ret)
   100			return ret;
   101	
 > 102		imx8qxp_ldb_set_phy_cfg(imx8qxp_ldb, di_clk, is_split, phy_cfg);
   103		ret = phy_validate(imx8qxp_ldb_ch->phy, PHY_MODE_LVDS, 0, &opts);
   104		if (ret < 0) {
   105			DRM_DEV_DEBUG_DRIVER(imx8qxp_ldb->dev,
   106					     "failed to validate PHY: %d\n", ret);
   107			return ret;
   108		}
   109	
   110		if (is_split && companion) {
   111			ret = companion->funcs->atomic_check(companion,
   112						bridge_state, crtc_state, conn_state);
   113			if (ret)
   114				return ret;
   115		}
   116	
   117		return ret;
   118	}
   119	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64731 bytes --]