From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2D0C433C1 for ; Mon, 22 Mar 2021 07:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6930661930 for ; Mon, 22 Mar 2021 07:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbhCVHjp (ORCPT ); Mon, 22 Mar 2021 03:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbhCVHjm (ORCPT ); Mon, 22 Mar 2021 03:39:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD87DC061574 for ; Mon, 22 Mar 2021 00:39:41 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOFA1-0002rH-Oz; Mon, 22 Mar 2021 08:39:37 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lOFA0-0007nU-To; Mon, 22 Mar 2021 08:39:36 +0100 Date: Mon, 22 Mar 2021 08:39:36 +0100 From: Michael Tretter To: Andrew Lunn Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, robh+dt@kernel.org, hkallweit1@gmail.com Subject: Re: [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree Message-ID: <20210322073936.GA31778@pengutronix.de> References: <20210319155710.2793637-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:13:54 up 32 days, 10:37, 79 users, load average: 0.75, 0.72, 0.58 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 19 Mar 2021 22:19:44 +0100, Andrew Lunn wrote: > On Fri, Mar 19, 2021 at 04:57:08PM +0100, Michael Tretter wrote: > > The dp83867 has 4 LED pins, which can be multiplexed with different functions > > of the phy. > > > > This series adds a device tree binding to describe the multiplexing of the > > functions to the LEDs and implements the binding for the dp83867 phy. > > > > I found existing bindings for configuring the LED modes for other phys: > > > > In Documentation/devicetree/bindings/net/micrel.txt, the binding is not > > flexible enough for the use case in the dp83867, because there is a value for > > each LED configuration, which would be a lot of values for the dp83867. > > > > In Documentation/devicetree/bindings/net/mscc-phy-vsc8532.txt, there is a > > separate property for each LED, which would work, but I found rather > > unintuitive compared to how clock bindings etc. work. > > > > The new binding defines two properties: one for the led names and another > > property for the modes of the LEDs with defined values in the same order. > > Currently, the binding is specific to the dp83867, but I guess that the > > binding could be made more generic and used for other phys, too. > > There is some work going on to manage PHY LEDs just like other LEDs in > Linux, using /sys/class/leds. > > Please try to help out with that work, rather than adding yet another > DT binding. Oh, thanks. That's even better. For reference: https://lore.kernel.org/netdev/20190813191147.19936-1-mka@chromium.org/ Michael