From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507A3C433DB for ; Mon, 22 Mar 2021 15:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0643A6198B for ; Mon, 22 Mar 2021 15:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229472AbhCVPDe (ORCPT ); Mon, 22 Mar 2021 11:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbhCVPDX (ORCPT ); Mon, 22 Mar 2021 11:03:23 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82F90C061574 for ; Mon, 22 Mar 2021 08:03:22 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a7so21817486ejs.3 for ; Mon, 22 Mar 2021 08:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=O31QmdEPE8zfYm16iYoljOKE1QkyhLPgMVq0vAViQFo=; b=R0mtls9VfFObvOXf8+wZV934gS6d+0c2O9zLGZkxmHGvOU1rhP8acTqAxzmOTpghs3 vShbYjAo+gUljVu5rWQtSiFGdxjPXdLw4sKaNPGqDZzAFG7lweHrp4FLBGnVYCXJx9aX 30mIkETX5EcakVx/bG9nviiGh29GiJOAwpREMUKVSdllIjA029lx0MhGW5GHoGrtEbkR RkK4FqXPzYt19HdCxQwQcqy1KfLgnF0Iw2LL7biGzFeDaJGiKnmWAvPrrJML52ajoarB 29Oy2B9FId2BQEGG95egOxxBCtq0Zpall5dOteJrfJRIcbBqRWVgdJjKq+h1l4QTFokr yMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=O31QmdEPE8zfYm16iYoljOKE1QkyhLPgMVq0vAViQFo=; b=SXsg+av03338882iBiwYPZq+ohBTpYUZNSx4fctWPZqxOtsAw1q+EfWa6kyaUYrd0o 84UgHbzDWpKyPEVq2ypsd9sPLYllH6QL9hHAKppKA5UhKh4W24dTR2F0xv2c1rGKtx5N 3Xvm0q8uqD/0Geh2T17v+KJZjB0DtcAuCbpr1HyTiugvraXXlEYIzixXxpRb8nQ3HvrX kzMOY69VKWRaRRT5AoBPLIXMc+ACna+HtqD0f7JH3g/2JjNGDn8ABntSFNYz5VK6aMFH iNI3SmE9VT0S1MXwM0LVm8GZsI0Y3hMmQB26zS79flWWLr9BLKCdmT57sGMzc93/rw1/ yrBg== X-Gm-Message-State: AOAM533vhi5IgzvTfjJSbUpKWGScXhcvYIruSuZBXR4WZjB8GiffFBBd l4p3TDTo2fndq52ACKfMf3lbBg== X-Google-Smtp-Source: ABdhPJwyBpi7zVzM9YJCyvxKjxLhikKRHzovcPsGaVR5YGucdcH2d6knkOTlZ8DSQtGF4ZqJHOq+/A== X-Received: by 2002:a17:906:a1c8:: with SMTP id bx8mr140079ejb.381.1616425401186; Mon, 22 Mar 2021 08:03:21 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id g7sm5434470ejw.51.2021.03.22.08.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 08:03:20 -0700 (PDT) Date: Mon, 22 Mar 2021 15:03:19 +0000 From: Lee Jones To: min.li.xe@renesas.com Cc: sameo@linux.intel.com, grant.likely@linaro.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support Message-ID: <20210322150319.GZ2916463@dell> References: <1616254985-28920-1-git-send-email-min.li.xe@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1616254985-28920-1-git-send-email-min.li.xe@renesas.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 20 Mar 2021, min.li.xe@renesas.com wrote: > From: Min Li > > Add support for ClockMatrix(TM) and 82P33xxx families of timing > and synchronization devices. The access interface can be either > SPI or I2C. Currently, it will create 2 types of MFD devices, > which are to be used by the corresponding rsmu character device > driver and the PTP hardware clock driver, respectively. > > Signed-off-by: Min Li > --- > drivers/mfd/Kconfig | 27 ++ > drivers/mfd/Makefile | 2 + > drivers/mfd/rsmu_i2c.c | 344 +++++++++++++++++ > drivers/mfd/rsmu_private.h | 32 ++ > drivers/mfd/rsmu_spi.c | 371 ++++++++++++++++++ > include/linux/mfd/idt82p33_reg.h | 102 +++++ > include/linux/mfd/idt8a340_reg.h | 817 +++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/rsmu.h | 42 ++ > 8 files changed, 1737 insertions(+) > create mode 100644 drivers/mfd/rsmu_i2c.c > create mode 100644 drivers/mfd/rsmu_private.h > create mode 100644 drivers/mfd/rsmu_spi.c > create mode 100644 include/linux/mfd/idt82p33_reg.h > create mode 100644 include/linux/mfd/idt8a340_reg.h > create mode 100644 include/linux/mfd/rsmu.h I'm pretty confused. This has been sent ~6 times already. What is the v1 of? Is this a different driver? If so, why does it have the same $SUBJECT line? If this is not actually v1. Please provide a change-log. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 49bb445..1202301 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1196,6 +1196,33 @@ config MFD_STW481X > endmenu > endif -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog