From: Andre Przywara <andre.przywara@arm.com>
To: Ivan Uvarov <i.uvarov@cognitivepilot.com>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v2 2/4] ARM: dts: sun8i: r40: add pinmux settings for MMC3 and UARTs 2,4,5&7
Date: Mon, 22 Mar 2021 16:24:11 +0000 [thread overview]
Message-ID: <20210322162411.1569bc4c@slackpad.fritz.box> (raw)
In-Reply-To: <20210322105538.3475183-3-i.uvarov@cognitivepilot.com>
On Mon, 22 Mar 2021 13:55:36 +0300
Ivan Uvarov <i.uvarov@cognitivepilot.com> wrote:
Hi,
> The Forlinx OKA40i-C devboard makes use of UARTs 0,2,3,4,5 and 7 of the R40
> SoC, of which UART 0 is connected to an RS232 converter, UART 5 routed to
> an RS485 converter, and the rest broken out directly via labeled headers.
> The board also contains a micro-SD slot connected to SDC3.
>
> This patch adds settings to R40's pinmux node for those UARTs that were not
> already mapped, which would allow us to make use of all available UARTs and
> the micro-SD slot on this board in a further patch.
>
> Signed-off-by: Ivan Uvarov <i.uvarov@cognitivepilot.com>
Looks alright, compared against the R40 manual.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
>
> 1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
> index 0b257a0779..51031a0e59 100644
> --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> @@ -357,6 +357,8 @@ mmc3: mmc@1c12000 {
> clock-names = "ahb", "mmc";
> resets = <&ccu RST_BUS_MMC3>;
> reset-names = "ahb";
> + pinctrl-0 = <&mmc3_pins>;
> + pinctrl-names = "default";
> interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> #address-cells = <1>;
> @@ -601,6 +603,14 @@ mmc2_pins: mmc2-pins {
> bias-pull-up;
> };
>
> + mmc3_pins: mmc3-pins {
> + pins = "PI4", "PI5", "PI6",
> + "PI7", "PI8", "PI9";
> + function = "mmc3";
> + drive-strength = <30>;
> + bias-pull-up;
> + };
> +
> /omit-if-no-ref/
> spi0_pc_pins: spi0-pc-pins {
> pins = "PC0", "PC1", "PC2";
> @@ -637,6 +647,18 @@ uart0_pb_pins: uart0-pb-pins {
> function = "uart0";
> };
>
> + /omit-if-no-ref/
> + uart2_pi_pins: uart2-pi-pins {
> + pins = "PI18", "PI19";
> + function = "uart2";
> + };
> +
> + /omit-if-no-ref/
> + uart2_rts_cts_pi_pins: uart2-rts-cts-pi-pins{
> + pins = "PI16", "PI17";
> + function = "uart2";
> + };
> +
> /omit-if-no-ref/
> uart3_pg_pins: uart3-pg-pins {
> pins = "PG6", "PG7";
> @@ -648,6 +670,24 @@ uart3_rts_cts_pg_pins: uart3-rts-cts-pg-pins {
> pins = "PG8", "PG9";
> function = "uart3";
> };
> +
> + /omit-if-no-ref/
> + uart4_pg_pins: uart4-pg-pins {
> + pins = "PG10", "PG11";
> + function = "uart4";
> + };
> +
> + /omit-if-no-ref/
> + uart5_ph_pins: uart5-ph-pins {
> + pins = "PH6", "PH7";
> + function = "uart5";
> + };
> +
> + /omit-if-no-ref/
> + uart7_pi_pins: uart7-pi-pins {
> + pins = "PI20", "PI21";
> + function = "uart7";
> + };
> };
>
> wdt: watchdog@1c20c90 {
next prev parent reply other threads:[~2021-03-22 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 10:55 [PATCH v2 0/4] add devicetree for Forlinx FETA40i-C & OKA40i-C Ivan Uvarov
2021-03-22 10:55 ` [PATCH v2 1/4] ARM: dts: sun8i: r40: add /omit-if-no-ref/ to pinmux nodes for UARTs 0&3 Ivan Uvarov
2021-03-22 16:18 ` Andre Przywara
2021-03-23 9:59 ` Ivan Uvarov
2021-03-25 14:12 ` Maxime Ripard
2021-03-22 10:55 ` [PATCH v2 2/4] ARM: dts: sun8i: r40: add pinmux settings for MMC3 and UARTs 2,4,5&7 Ivan Uvarov
2021-03-22 16:24 ` Andre Przywara [this message]
2021-03-22 10:55 ` [PATCH v2 3/4] dt-bindings: arm: add compatible strings for Forlinx OKA40i-C Ivan Uvarov
2021-03-22 16:27 ` Andre Przywara
2021-03-22 10:55 ` [PATCH v2 4/4] ARM: dts: sun8i: r40: add devicetree for Forlinx FETA40i-C & OKA40i-C Ivan Uvarov
2021-03-22 16:47 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322162411.1569bc4c@slackpad.fritz.box \
--to=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=i.uvarov@cognitivepilot.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).