From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2543EC433E1 for ; Wed, 24 Mar 2021 20:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF13261A1F for ; Wed, 24 Mar 2021 20:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238052AbhCXUHe (ORCPT ); Wed, 24 Mar 2021 16:07:34 -0400 Received: from mail-io1-f52.google.com ([209.85.166.52]:46738 "EHLO mail-io1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238170AbhCXUHJ (ORCPT ); Wed, 24 Mar 2021 16:07:09 -0400 Received: by mail-io1-f52.google.com with SMTP id j26so22833236iog.13; Wed, 24 Mar 2021 13:07:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kQ8EfIai0iW2bIIQK0w4Z5qSxl9rVxcELF+Eo3Tf2YU=; b=kOgr6ar5LmlJ3xK+vriwT8/Ry6ZRS8goKGCg72ztIl6EvL3K3FwJfdz+CcBNGgc+qe MrtBmVpgA+SxIrpglEQAg/1Iu3HKSyQHamgUu1WdmsvoO4XqtSTturG3IH6IGutCB8pC kslyyJ/33v/5emjtTic7KhpLqf4hqV3zAED8dCsEqlPlBGe/zUULb2RDgdXfLxjhj68G mARWYbzLMClu2Nh4dDwTusaDPzK1VrTgu+zmDNN14aKMP712/Popx1b10wanZ1DXz8R3 I76bMTG/DHM8BMKbw+guiRSDe1cyONocObpkGmH5ODIBu6G0/Ofl0D8TOBqpvZsSwHoF KPaQ== X-Gm-Message-State: AOAM5302oxQEvZibMPHq51/98aBuPgZmeKVQcpqUX90/C1z2CW2+jcpQ Wd8NBZirD9OlEJeXJho3UA== X-Google-Smtp-Source: ABdhPJx0+97Pr/JkbHMlL2UCLm05Zhgoan9kw7ATFj5Cv/Hz995ecWbwg/NXjiAh3m4sMsXnmG31Eg== X-Received: by 2002:a05:6638:378c:: with SMTP id w12mr4456448jal.127.1616616428402; Wed, 24 Mar 2021 13:07:08 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id z12sm1619693ilb.18.2021.03.24.13.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 13:07:07 -0700 (PDT) Received: (nullmailer pid 3539458 invoked by uid 1000); Wed, 24 Mar 2021 20:07:06 -0000 Date: Wed, 24 Mar 2021 14:07:06 -0600 From: Rob Herring To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Florian Fainelli , Heiner Kallweit , Russell King , devicetree@vger.kernel.org, pali@kernel.org Subject: Re: [PATCH net-next 1/2] dt-bindings: ethernet-controller: create a type for PHY interface modes Message-ID: <20210324200706.GA3528805@robh.at.kernel.org> References: <20210324103556.11338-1-kabel@kernel.org> <20210324103556.11338-2-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210324103556.11338-2-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Mar 24, 2021 at 11:35:55AM +0100, Marek Behún wrote: > In order to be able to define a property describing an array of PHY > interface modes, we need to change the current scalar > `phy-connection-type`, which lists the possible PHY interface modes, to > an array of length 1 (otherwise we would need to define the same list at > two different places). > > Moreover Rob Herring says that we cannot reuse the values of a property; > we need to $ref a type. > > Move the definition of possible PHY interface modes from the > `phy-connection-type` property to an array type definition > `phy-connection-type-array`, and simply reference this type in the > original property. Why not just extend phy-connection-type to support more than 1 entry?